bugBattle for Wesnoth - Bugs: bug #21906, replays can change global variables

Show feedback again

bug #21906: replays can change global variables

Submitted by:  Daniel <gfgtdf>
Submitted on:  Sat Apr 12 01:25:20 2014  
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: WML
Status: FixedPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: 1.13-devOperating System: windows

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Thu Mar 23 17:53:08 2017, comment #2:

yes seesm to be fixed

Daniel <gfgtdf>
Project Member
Sat Oct 17 10:26:48 2015, comment #1:

Is this still an issue? I can't find the quoted bit of code in 1.13.1+dev. I do see an experimental replay check using set_global_variable at around line 651 of src/game_events/action_wml.cpp. I'm not too familiar with the WML code but I've notice lots of work on it in recent months, so maybe it's been changed.

Wedge009 <wedge009>
Project Member
Sat Apr 12 01:25:20 2014, original submission:

we currently check for beeing in a replay in set_global_variable with 'if (get_replay_source().at_end() || (network::nconnections() != 0))'
however, this obviously doesn't work if the currently executed command is the last one in the replay, becasue in that case at_end() will return true.
(I also tested this.)

Daniel <gfgtdf>
Project Member


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by wedge009 (Posted a comment)
  • -unavailable- added by gfgtdf (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu Mar 23 17:53:08 2017gfgtdfStatusNone=>Fixed
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup