bugBattle for Wesnoth - Bugs: bug #21929, multiplayer -> load game dialog...

 
 
Show feedback again

bug #21929: multiplayer -> load game dialog should correctly handle replays

Submitted by:  Chris Beck <involution>
Submitted on:  Wed 16 Apr 2014 09:21:19 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 1.12,1.13-devOperating System: any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Apr 2014 12:24:30 AM UTC, comment #3:

"even when the "this scenario has no id" bug is fixed what you expect to happen whe you click waetch replay in mp? "

I'd expect the replay controller to be launched, similarly to to the SP -> Load game option. Ideally this would happen by a code path that would definitely not do SP specific things, and we wouldn't have the warning "this is an mp scenario. some things may not work properly" etc.

"So being able to watch a replay together with others via network would require completeley new code and i would consider it rather a feature than a bug that this is not possible."

Yes ofc I agree, in fact I think that is actually a feature request already.

"Since you can still watch mp replays in the normal load game dilaog i'd be ok if we just disable tht button in mp load game dialog, maybe we should make that warning message disappear in this case though."

No that would be a mistake. The replay check box in the load game dialog serves a useful purpose, it determine whether we will load from snapshot or from replay_start and replay.

Chris Beck <involution>
Project Member
Fri 18 Apr 2014 10:58:13 PM UTC, comment #2:

even when the "this scenario has no id" bug is fixed what you expect to happen whe you click waetch replay in mp?
We currently have different codepaths for watching replays (replay_controller) and mp games (playmp_controller). So being able to watch a replay together with others via network would require completeley new code and i would consider it rather a feature than a bug that this is not possible. Since you can still watch mp replays in the normal load game dilaog i'd be ok if we just disable tht button in mp load game dialog, maybe we should make that warning message disappear in this case though.

Anonymous
Wed 16 Apr 2014 10:31:01 PM UTC, comment #1:

gfgtdf points out that this is most likely the same as the unsolved portion of this bug: https://gna.org/bugs/?20895

Chris Beck <involution>
Project Member
Wed 16 Apr 2014 09:21:19 PM UTC, original submission:

right now it fails with "this scenario has no id", and if that check is disabled, with "this scenario has no sides". i would think that we would be able to detect a replay and launch the replay_controller, similarly to how we do for title screen -> load game.

Chris Beck <involution>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by involution (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup