bugBattle for Wesnoth - Bugs: bug #21939, server should not send...

 
 
Show feedback again

bug #21939: server should not send change_controller to sides lingering on prev level

Submitted by:  Chris Beck <involution>
Submitted on:  Sat 19 Apr 2014 04:43:29 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: anyOperating System: any

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 24 Apr 2014 12:20:19 AM UTC, comment #1:

This was fixed by changing linger mode in networked mp so that all non-host clients transition immediately when the host makes the level available to them. Commit here:

https://github.com/wesnoth/wesnoth/commit/35f781d428aed486752d65d01624d9a236a363d5

Should we decide to go back to old linger mode behavior at some point in the future, there will need to be a more complicated fix, most likely reverting this and changing server-side code.

Chris Beck <involution>
Project Member
Sat 19 Apr 2014 04:43:29 PM UTC, original submission:

This seems to affect all versions of wesnoth, however it is more annoying in 1.12, 1.13-dev because with the server side controller tweaks this leads to "illegal whiteboard data" messages whenever we transition afaik.

I believe that it does not actually cause problems beyond what we had in 1.10 however, and that it could be fixed with a solely server-side patch that keeps track for each player whether they have transitioned from linger mode or not, and filters for this when sending [change_controller] signals.

Chris Beck <involution>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by involution (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 May 2014 10:42:39 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Thu 24 Apr 2014 12:20:19 AM UTCinvolutionStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup