bugBattle for Wesnoth - Bugs: bug #21978, Inconsistent lock behavior when...

 
 
Show feedback again

bug #21978: Inconsistent lock behavior when 'use map settings' unchecked

Submitted by:  SigurdFireDragon <sigurdfdragon>
Submitted on:  Sat 26 Apr 2014 07:02:19 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Multiplayer
Status: FixedPrivacy: Public
Assigned to: Andrius Silinskas <thunderstruck>Open/Closed: Closed
Release: 1.11.13+devOperating System: Win 7 x64

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 26 Jun 2014 09:37:17 PM UTC, comment #2:

Fixes are also on master now.

Andrius Silinskas <thunderstruck>
Project MemberIn charge of this item.
Thu 26 Jun 2014 09:04:48 PM UTC, comment #1:

Should be fixed in https://github.com/wesnoth/wesnoth/commit/87b3ba53771feb6ea12148280077e35a999f1b65 and https://github.com/wesnoth/wesnoth/commit/a35e8a6093dda5fc01696a727c96ab7fd64e62ac.

I made it so that 'controller_lock' behaves identically as other locks when 'use_map_settings' is (un)checked. As for factions and leaders, I added new 'faction_lock' and 'leader_lock' keys to for the sake of consistency.

I'll second commit is till not in master, but soon will be there.

Andrius Silinskas <thunderstruck>
Project MemberIn charge of this item.
Sat 26 Apr 2014 07:02:19 PM UTC, original submission:

In a multiplayer scenario or campaign:

When 'use map settings' is unchecked, using the various individual lock keys has an inconsistent behavior. Controller_lock=yes will still work, but others like gold_lock, income_lock, color_lock & team_lock = yes will not. Using faction=Loyalist on default makes it suggested to the player, but the player can still change it.

It seems to me that keys like gold, income, color & team_lock should still be able to be used if 'use_map_settings' is unchecked.

I'm not sure what I would consider proper behavior for the faction key.

Attached is a test scenario where one can toggle use map settings to see behavior described above.

SigurdFireDragon <sigurdfdragon>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #20585:  Multiplayer_Lock_Test.zip added by sigurdfdragon (1kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by thunderstruck (Updated the item)
  • -unavailable- added by sigurdfdragon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 15 Jul 2014 06:33:39 PM UTCthunderstruckOpen/ClosedOpen=>Closed
    Tue 15 Jul 2014 06:33:27 PM UTCthunderstruckStatusReady For Test=>Fixed
    Thu 26 Jun 2014 09:04:48 PM UTCthunderstruckStatusNone=>Ready For Test
    Sat 10 May 2014 06:44:49 AM UTCthunderstruckAssigned toNone=>thunderstruck
    Sat 26 Apr 2014 07:02:19 PM UTCsigurdfdragonAttached File-=>Added Multiplayer_Lock_Test.zip, #20585
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup