bugBattle for Wesnoth - Bugs: bug #22030, [disable] weapon special broken

 
 
Show feedback again

bug #22030: [disable] weapon special broken

Submitted by:  Lari Nieminen <zookeeper>
Submitted on:  Sat 10 May 2014 09:37:17 AM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: WML
Status: FixedPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: 1.11.13Operating System: all

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 10 May 2014 11:53:13 AM UTC, comment #1:

Should be fixed in 9b1a223b3d36dc539126527656a67806d6fe64fb

The attack GUI index result value didn't match the attack value because the items are taken out of a list if 'disabled'

I added an increment vector to compensate for each 'disabled' item as a vector that is saved before the attack, to account for the case where disable may be applied during an attack to a weapon.

David Mikos <coffee>
Project Member
Sat 10 May 2014 09:37:17 AM UTC, original submission:

The attack dialog doesn't correctly account for attacks disabled with the [disable] special; if for example a unit's first attack is [disable]d, choosing the remaining second attack in the attack dialog results in the first attack (which is supposed to be disabled) to be used. Disabling the unit's second attack instead (assuming the unit only has two attacks) works correctly.

Lari Nieminen <zookeeper>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by coffee (Posted a comment)
  • -unavailable- added by zookeeper (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 28 May 2014 10:45:17 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 10 May 2014 11:53:13 AM UTCcoffeeStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup