bugSavane - Bugs: bug #2204, browsing items with the...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #2204: browsing items with the "should be finished on" field, item still open that should be finished should be highlighted

Submitted by:  Mathieu Roy <yeupou>
Submitted on:  Fri 01 Apr 2005 08:45:42 AM UTC  
 
Category: Web Frontend: TrackersStatus: Fixed
Severity: 1 - WishPriority: C - Normal
Assigned to: Tobias Quathamer <toddy>Open/Closed: Closed
Release: Planned Release: 1.1
Reproducibility: NonePrivacy: Public

(Jump to the original submission Jump to the original submission)

Thu 08 Sep 2005 10:58:41 AM UTC, comment #6:

I understand the issue but removing it not satisfactory either, because this padding: 1% have to be here for the others cases.

We maybe should add a "highlight" class for cases like this where boxhighlight cannot be used.

Mathieu Roy <yeupou>
Project Administrator
Thu 08 Sep 2005 10:16:53 AM UTC, comment #5:

That is due to the "padding: 1%;", which has to make the box on the outside bigger, although the space for the padding is added on the inside.

The reason is simple: If you want to have more space around the content, you've got two options. First, make the content smaller and keep the outer size; second, keep the content and make the outer size bigger. The browser then adjusts the outer size, which is normally the right thing to do.

You can see the result without "padding: 1%;" on the test install, I've temporarily removed the padding statement from the gna css theme.

Tobias Quathamer <toddy>
Project MemberIn charge of this item.
Thu 08 Sep 2005 09:44:47 AM UTC, comment #4:

That's nice, but there a slight problem (maybe not with all themes, at least with the gna one), the boxhiglight modifies the size of the box, as visible in the attached screenshot.

It should not happen, considering the css, but it does, I'm not sure why exactly

.boxitem {
background-color: #fafafa;
padding: 1%;
border: solid #b0b0b0;
border-width: 0 thin thin thin;
}
.boxitemalt {
background-color: #dbdbdb;
padding: 1%;
border: solid #b0b0b0;
border-width: 0 thin thin thin;
}

.boxhighlight {
border-bottom: solid #5080c0;
background-color: #c4dbe4;
padding: 1%;
border: solid #b0b0b0;
border-width: 0 thin thin thin;
}

Mathieu Roy <yeupou>
Project Administrator
Thu 08 Sep 2005 09:23:08 AM UTC, comment #3:

Yes. You can see the working code in the test install.

Tobias Quathamer <toddy>
Project MemberIn charge of this item.
Wed 07 Sep 2005 05:29:32 PM UTC, comment #2:

But I only on the "should be finished on column" right?

Mathieu Roy <yeupou>
Project Administrator
Wed 07 Sep 2005 04:52:48 PM UTC, comment #1:

I've changed the code to use the CSS class "boxhighlight" for the highlighting.

Tobias Quathamer <toddy>
Project MemberIn charge of this item.
Fri 01 Apr 2005 08:45:42 AM UTC, original submission:

While browsing items with the "should be finished on" field, item still open that should be finished should be highlighted.

"Should be finished on" is mainly used on the task tracker.

- It could be highlighted by putting the whole line in bold (but this kind of highlighting limits us, as we will not be able to highlight anything else).
- We could use a specific icon (but we should not abuse of icons, otherwise people will have to get a Savane driving license - there are already a bunch of icons -- useful I think)
- It could be highlighted by putting only the should be finished on column, of the relevant row, in the css element boxhighlight. Simple and probably cleanest solution.

Both option 2 and 3 seems fine.

Mathieu Roy <yeupou>
Project Administrator

 

Attached Files
file #174:  issue.jpg added by yeupou (206kB - image/jpeg)

 

Depends on the following items: None found

Items that depend on this one

Digest:
   task dependencies.

 

Carbon-Copy List
  • -unavailable- added by toddy (Updated the item)
  • -unavailable- added by yeupou (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 08 Sep 2005 09:44:47 AM UTCyeupouAttached File-=>Added issue.jpg, #179
    Wed 07 Sep 2005 04:42:24 PM UTCtoddyStatusNone=>Fixed
      Assigned toNone=>toddy
      Open/ClosedOpen=>Closed
      Planned Release=>1.1
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup