bugBattle for Wesnoth - Bugs: bug #22046, Error when selecting small gui...

 
 
Show feedback again

bug #22046: Error when selecting small gui elements

Submitted by:  Daniel <gfgtdf>
Submitted on:  Sat 17 May 2014 07:47:15 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Mark de Wever <mordante>Open/Closed: Closed
Release: 1.13.0-devOperating System: win7

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 15 Jul 2014 06:36:39 PM UTC, comment #6:

Shadowm reminded me the fix was not backported to 1.12 yet, e74fb902e335 does that job.

Mark de Wever <mordante>
Project MemberIn charge of this item.
Sat 14 Jun 2014 12:44:54 PM UTC, comment #5:

Thanks for the additional information. I was able to reproduce the issue and it's fixed with 02b761b24eb6.

Mark de Wever <mordante>
Project MemberIn charge of this item.
Mon 09 Jun 2014 11:00:50 PM UTC, comment #4:

I dont have the original code which gave me the original error. I tried to reproduce the error with the following code:
(place the start event in any scenario.)

but instead of the bug with h < 0 it gives ma a similar error with w < 0. (line 1114 instead of 1119). I checked this at commit 51a2c0443fd8a381c88df8411f97bdf7da93c719.

Daniel <gfgtdf>
Project Member
Mon 09 Jun 2014 10:56:33 PM UTC, comment #3:
Daniel <gfgtdf>
Project Member
Mon 09 Jun 2014 05:16:31 PM UTC, comment #2:

I fixed bug #22144. gfgtdf can you verify whether it also solves the issue for you. If not, can you give me a test case?

Mark de Wever <mordante>
Project MemberIn charge of this item.
Fri 06 Jun 2014 12:34:45 PM UTC, comment #1:

bug #22144 is a specific case of this.

Alexander van Gessel <ai0867>
Project Member
Sat 17 May 2014 07:47:15 PM UTC, original submission:

When i select gui elements that are very small i get an error message about canvas.cpp line 1119 that h < 0.
The reason i think is, that in https://github.com/wesnoth/wesnoth/blob/master/data/gui/default/macros/_initial.cfg#L131 we use (height - 20) for dialogs/selection-border-left.png s height, which is obiously less than 0 as soon as the height is smaller than 20.

Daniel <gfgtdf>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by mordante (Posted a comment)
  • -unavailable- added by ai0867 (Posted a comment)
  • -unavailable- added by gfgtdf (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 12 Oct 2014 12:21:07 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 14 Jun 2014 12:44:54 PM UTCmordanteStatusReady For Test=>Fixed
    Mon 09 Jun 2014 05:16:31 PM UTCmordanteStatusNone=>Ready For Test
      Assigned toNone=>mordante
    Sat 17 May 2014 07:47:36 PM UTCgfgtdfSummaryError when selectiong small gui elements=>Error when selecting small gui elements
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup