bugFreeciv - Bugs: bug #22082, Lua disaster signal can't suppress...

 
 
Show feedback again

bug #22082: Lua disaster signal can't suppress message "We survived the disaster without serious damages."

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 25 May 2014 11:08:34 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: Any
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 29 May 2014 08:20:25 PM UTC, comment #2:

In S2_5 we can't move it to lua as the signal does not tell if some of the engine side effects fired.

So in S2_5 we should just get rid of the message.

In TRUNK we should at least pass boolean in lua signal telling if any of the internal effects fired. It's more complicated question if we then use that information in default.lua or ruleset specific script.lua.

Marko Lindqvist <cazfi>
Project Administrator
Mon 26 May 2014 06:57:44 AM UTC, comment #1:

> Perhaps we can move the emission of the message to a default signal handler in default.lua instead, and make emitting the message ruleset Lua's responsibility?


I agree.

J. M. Gorbach <gorb>
Sun 25 May 2014 11:08:34 AM UTC, original submission:

In apply_disaster(), if none of the built-in disasters fire, the message "We survived the disaster without serious damages." is emitted before the script signal fires. This may be unwanted for disasters implemented in Lua.

Unfortunately I don't think there's any way for the Lua signal handler to return whether a disaster occurred. Perhaps we can move the emission of the message to a default signal handler in default.lua instead, and make emitting the message ruleset Lua's responsibility?

(Alternatively we could just get rid of the message.)

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by gorb (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup