bugFreeciv - Bugs: bug #22117, Executables rebuilt during...

 
 
Show feedback again

bug #22117: Executables rebuilt during "make install" (with --enable-svnrev?)

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 01 Jun 2014 12:04:30 AM UTC  
 
Category: NoneSeverity: 2 - Minor
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: S2_4 r24991Operating System: Any
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 01 Jun 2014 01:18:30 AM UTC, comment #1:

> I have --enable-svnrev. My guess is that is introducing some
> unconditional dependency that causes version.l(o) to be rebuilt
> whenever it's referenced?


fc_svnrev_gen.h and fc_gitrev_gen.h are always generated directory is configured to use them. Can't help that as any change in any part of the source tree could cause change in them.
However, it shouldn't replace the old file if newly generated one is identical.

My theory is that 'make install' handles translations first. That has the nasty way of making local modifications to .po files. When fc_svnrev_gen.h is then generated, it notices that svn checkout has local modifications and gets the version in form "modified r24991" while first "make" pass resulted in plain "r24991". Does your installed version show version number in that format?

Anyway, I think "make install" should nowadays get the dependency handling right, so you wouldn't need plain "make" first.

Marko Lindqvist <cazfi>
Project Administrator
Sun 01 Jun 2014 12:04:30 AM UTC, original submission:

(Been meaning to report this for a while; please excuse vagueness.)

In my svn client where I usually do "make && make install", I've noticed that binaries like "freeciv-gtk2" are all built twice.
I think the second build is during "make install".

I have --enable-svnrev. My guess is that is introducing some unconditional dependency that causes version.l(o) to be rebuilt whenever it's referenced?

I haven't checked any of these guesses, though. I can do more digging if useful.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup