bugBattle for Wesnoth - Bugs: bug #22135, leader facing attribute is not...

 
 
Show feedback again

bug #22135: leader facing attribute is not synchronized

Submitted by:  Chris Beck <involution>
Submitted on:  Tue 03 Jun 2014 07:45:10 PM UTC  
 
Category: BugSeverity: 2 - Minor
Priority: 5 - NormalItem Group:  None of the others
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 1.13.0-devOperating System: Linux Mint 16

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 03 Jun 2014 07:45:10 PM UTC, original submission:

Although we made unit recruit facing directions synchronized for mp play and replays in this commit:

https://github.com/wesnoth/wesnoth/commit/311d7bad807a3e509fd6a17e869c4a776416655d

we appare not to have done this for units created by team_builder at the start of game, so at the start of any mp game, the leader facing directions will not be synchronized (easy to check the leader with an observer for a default mp game. The units that are recruited on turn 1 will be synced in terms of what direction they face, but the leaders will not be at turn 1. However if they move then I guess they will be synced.)

Most likely this also affects units created in [side] tags of any scenario. In that case it could be more serious, and actually cause oos in hypothetical UMC scenario that assumes that these attributes are synced, i.e. if there were a "real backstab" ability that checks which direction a unit is facing.

Chris Beck <involution>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by involution (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup