bugFreeciv - Bugs: bug #22138, Server wants us to remove unit id...

 
 
Show feedback again

bug #22138: Server wants us to remove unit id 109, but we don't know about this unit!

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 03 Jun 2014 11:26:02 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: S2_5 r25043Operating System: Any
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 25 Jun 2014 01:54:27 PM UTC, SVN revision 25269:

When removing a unit from the game (server side), clear the vision before
sending unit remove. Else, we might duplicate the PACKET_UNIT_REMOVE if we lose
vision of the unit tile.

From a report by Jacob Nevins (jtn@gna)

See gna bug #22138

(Browse SVN revision 25269)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 25 Jun 2014 01:54:19 PM UTC, SVN revision 25268:

When removing a unit from the game (server side), clear the vision before
sending unit remove. Else, we might duplicate the PACKET_UNIT_REMOVE if we lose
vision of the unit tile.

From a report by Jacob Nevins (jtn@gna)

See gna bug #22138

(Browse SVN revision 25268)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 19 Jun 2014 08:18:24 AM UTC, comment #3:

You got this error message because of PACKET_UNIT_REMOVE duplicate. In server_remove_unit(), this packet is sent to you at the start of the function. And when it clears unit vision, as you explorer lost vision of its own tile, it has gone out of sight, causing the duplicate.

It appeared to me that the order is not correct. It should remove the vision first, and send unit removing after that if the unit is still visible.

Attached patch (to apply over bug #22222).

(file #21088)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 10 Jun 2014 01:53:21 PM UTC, comment #2:

I think this is caused by a hack in wipe_unit(), commented by Jason for PR#14649 (r11263):

I think that create_city() should remove units no more seen. Also remove_city() should send unit infos on the tiles. Using editor, it is clearly buggy.

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 06 Jun 2014 03:13:02 AM UTC, comment #1:

> pepeto's check of patch #4725 is triggering readily for me


Oh, that went to stable branch too. I hope we get all the cases triggering it fixed quickly then. I still hope that we would get 2.5.0-beta1 out before we have to start thinking about 2.4.3 release.

Marko Lindqvist <cazfi>
Project Administrator
Tue 03 Jun 2014 11:26:02 PM UTC, original submission:

pepeto's check of patch #4725 is triggering readily for me... for instance, with file #20920, my Explorer is auto-exploring and on T47 gets killed by a Persian catapult, and the client gets the message "Server wants us to remove unit id 109, but we don't know about this unit!"

Also seen this in a different run followed by the same message, not sure if it's related:

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Digest:
   bug dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 25 Jun 2014 01:54:40 PM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Thu 19 Jun 2014 08:18:24 AM UTCpepetoAttached File-=>Added server_remove_unit_clear_sight.patch, #21088
      StatusNone=>Ready For Test
      Planned Release2.5.0=>2.5.0, 2.6.0
    Thu 19 Jun 2014 08:13:56 AM UTCpepetoDependencies-=>Depends on bugs #22222
    Wed 18 Jun 2014 10:06:59 AM UTCpepetoAssigned toNone=>pepeto
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup