bugBattle for Wesnoth - Bugs: bug #22147, networking instability in linger...

 
 
Show feedback again

bug #22147: networking instability in linger mode

Submitted by:  Chris Beck <involution>
Submitted on:  Fri 06 Jun 2014 05:17:01 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group:  None of the others
Status: FixedPrivacy: Public
Assigned to: Daniel <gfgtdf>Open/Closed: Closed
Release: 1.12Operating System: Linux Mint 16

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 08 Oct 2014 05:36:29 PM UTC, comment #4:

backported commit in https://github.com/wesnoth/wesnoth/commit/1b8199685e2178a380edfbd8c4d2af65868d9731

Daniel <gfgtdf>
Project MemberIn charge of this item.
Sat 07 Jun 2014 10:12:51 PM UTC, comment #3:

ok i tested in master, it looks fixed to me. i think should backport to 1.12.

Chris Beck <involution>
Project Member
Fri 06 Jun 2014 10:31:47 PM UTC, comment #2:

ok i commited e3f7f2bcbc64a679f780919ebaf0ef9de775a1a3 to master which should fix.

Daniel <gfgtdf>
Project MemberIn charge of this item.
Fri 06 Jun 2014 07:58:20 PM UTC, comment #1:

did you get a "Error network: found unexpected attribute: ..." or similar in the log ?

Anonymous
Fri 06 Jun 2014 05:17:01 PM UTC, original submission:

If clients lose connection from the host while in linger mode at the end of a networked mp scenario, host, client and obs all crash.

wesnoth: src/playturn_network_adapter.cpp:73: bool playturn_network_adapter::read(config &): Assertion `!is_at_end()' failed.
./client: line 2: 13535 Aborted ./wesnoth/wesnoth --data-dir ./wesnoth/ --server localhost:12345 --log-debug=enginerefac,mp/connect/engine,network $*

Test procedure:
Launch a local wesnothd instance and 3 connected clients. Set two of them to fight, and the third to observer. Then, during linger mode, kill the server with a kill signal. The other three clients will crash as well.

Alternatively, connect to the main server, let the game run to completion, then turn off your wifi and let the connection time out.

I didn't test yet what happens if these kinds of things happen before linger mode is entered.

Chris Beck <involution>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by gfgtdf (Posted a comment)
  • -unavailable- added by involution (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 12 Oct 2014 12:21:54 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Wed 08 Oct 2014 05:49:57 PM UTCgfgtdfStatusReady For Test=>Fixed
    Wed 08 Oct 2014 05:36:29 PM UTCgfgtdfAssigned toNone=>gfgtdf
    Sat 07 Jun 2014 10:00:28 PM UTCgfgtdfStatusNone=>Ready For Test
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup