bugFreeciv - Bugs: bug #22158, tech_upkeep_style 'Cities' vs...

 
 
Show feedback again

bug #22158: tech_upkeep_style 'Cities' vs team_pooled_research

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 08 Jun 2014 12:30:06 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Duplicate
Assigned to: NoneOpen/Closed: Closed
Release: Operating System: None
Planned Release: 

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 06 Oct 2014 11:09:25 PM UTC, comment #5:

> I think patch #5099 will fix this on S2_5 and S2_4 too?


It is supposed to.

pepeto <pepeto>
Project Member
Mon 06 Oct 2014 10:59:38 PM UTC, comment #4:

I think patch #5099 will fix this on S2_5 and S2_4 too?

Jacob Nevins <jtn>
Project Administrator
Sun 03 Aug 2014 12:27:06 AM UTC, comment #3:

> Depending on how bug #22058 turns out, no further code change
> may be necessary to get the behaviour we want.

I think the result of bug #22058 is OK, so closing this.

Jacob Nevins <jtn>
Project Administrator
Wed 18 Jun 2014 11:11:28 PM UTC, comment #2:

> The way I see it, I think the upkeep should take into acount
> all the cities from all the players on the same team, as you
> point.

Thanks for the ruling.

> If the tech upkeep is shared and paid only once per team [...]

There's the rub.

Looking at the code, I think currently you get a random team member's cities multiplied by the number of team members(!) -- see bug #22058.

Making the obvious change to tech_upkeep_calc() would make upkeep the number of cities in the team * the number of team members, which is too much (penalises big teams).

Depending on how bug #22058 turns out, no further code change may be necessary to get the behaviour we want.

In the meantime, I fear we have to declare the combination of team_pooled_research and tech_upkeep irretrievably broken, and just remember that this is the behaviour we want from tech_upkeep_style "Cities" when we get round to fixing it.
(Since team_pooled_research is enabled by default, that means civ2civ3 team games will not do the right thing. And we keep finding other bugs when team_pooled_research is disabled.)

Accordingly, dumping this on the "player research" metaticket for now.

Jacob Nevins <jtn>
Project Administrator
Fri 13 Jun 2014 02:50:40 PM UTC, comment #1:

The way I see it, I think the upkeep should take into acount all the cities from all the players on the same team, as you point.

The original idea of this new style was to redefine the tech upkeep as "the bulbs needed per city".
When the tech upkeep is 10, one player should pay 10 bulbs per city, and 4 players in same team should also pay 10 bulbs per city.

If the tech upkeep is shared and paid only once per team, I think it should take into account all the cities owned by the team.

David Fernandez <bardo>
Sun 08 Jun 2014 12:30:06 AM UTC, original submission:

The new tech_upkeep_style added in bug #19589 makes upkeep proportional to the players' city count.

In the case of a team with team_pooled_research enabled, should it be proportional to the total number of cities across all players on the team? Their science output is likely to be proportional to that.

(Bug #22058 suggests that the two might be effectively incompatible at the moment anyway.)

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Digest:
   bug dependencies.

Digest:
   patch dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by bardo (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 11 Oct 2014 03:27:11 PM UTCjtnPlanned Release2.6.0=>
    Sun 03 Aug 2014 12:27:06 AM UTCjtnStatusNone=>Duplicate
      Open/ClosedOpen=>Closed
      Planned Release=>2.6.0
    Wed 18 Jun 2014 11:11:37 PM UTCjtnDependencies-=>Depends on bugs #22058
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup