bugFreeciv - Bugs: bug #22161, Prevent loss of self root_req...

 
 
Show feedback again

bug #22161: Prevent loss of self root_req technologies

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 08 Jun 2014 01:03:25 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 7 - HighStatus: Fixed
Assigned to: Jacob Nevins <jtn>Open/Closed: Closed
Release: Operating System: Any
Planned Release: 2.4.3, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 27 Jun 2014 07:13:00 PM UTC, SVN revision 25293:

Prevent tech loss removing self root_req techs.

See bug #22161.

(Browse SVN revision 25293)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 27 Jun 2014 07:11:57 PM UTC, SVN revision 25291:

Prevent tech loss removing self root_req techs.

See bug #22161.

(Browse SVN revision 25291)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Fri 27 Jun 2014 07:09:26 PM UTC, SVN revision 25289:

Prevent tech loss removing self root_req techs.

See bug #22161.

(Browse SVN revision 25289)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Mon 09 Jun 2014 09:37:22 AM UTC, comment #2:

> You mean like "if you want this bug not to exist, you need to
> use 2.4.3 at least"

That's what I intended.

> Changes that have already went in mostly affect only client
> GUI, making it more usable for use with such rulesets

Ah, that's true, on looking closer -- unlike this patch, no game rules have actually changed (although the AI would have not coped well without patch #4410, I'm guessing?)

I'm still inclined to put this on 2.4 -- it can be viewed as fixing a bug in the combination of tech upkeep and root_reqs.

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.
Sun 08 Jun 2014 07:56:00 PM UTC, comment #1:

> (Targeting to S2_4 means that root_req rulesets require a
> minimum minor version, but that's already true with all the
> fixes that went in 2.4.2, I think.)


You mean like "if you want this bug not to exist, you need to use 2.4.3 at least", or actual datafile format freeze breakage? Changes that have already went in mostly affect only client GUI, making it more usable for use with such rulesets (but we've officially supported such rulesets for a very long time)

Marko Lindqvist <cazfi>
Project Administrator
Sun 08 Jun 2014 01:03:25 PM UTC, original submission:

Split out from bug #19176:

Random tech loss can currently get rid of a self-root_req'd technology, i.e. one you can only acquire by special means (such as being given it at the start of the game).

This is a barrier to implementing rulesets with multiple tech trees, since all tech loss must be forced off for such rulesets to be usable.

Since we've cleaned up a lot of other blocking issues with root_reqs recently (bug #17887) I think we should fix this at a minimum.
(Targeting to S2_4 means that root_req rulesets require a minimum minor version, but that's already true with all the fixes that went in 2.4.2, I think.)

I think it should be uncontroversial that these cannot be lost through the tech system, since they can't be gained through it.

(The special case of self-root_req techs is simpler than the general case of bug #19176, since we don't have to worry about diplomatic transfer, stealing, etc -- all of these are impossible for such technologies.)

Jacob Nevins <jtn>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21153:  trunk-S2_5-techloss-selfrootreq.patch added by jtn (2kB - text/x-diff - trunk/S2_5/S2_4 r25269)
file #21154:  S2_4-techloss-selfrootreq.patch added by jtn (3kB - text/x-diff - trunk/S2_5/S2_4 r25269)

 

Depends on the following items: None found

Items that depend on this one

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 27 Jun 2014 07:15:22 PM UTCjtnStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 25 Jun 2014 11:54:51 PM UTCjtnAttached File-=>Added trunk-S2_5-techloss-selfrootreq.patch, #21153
      Attached File-=>Added S2_4-techloss-selfrootreq.patch, #21154
      StatusNone=>Ready For Test
      Assigned toNone=>jtn
    Sun 08 Jun 2014 01:05:46 PM UTCjtnDependencies-=>bugs #19176 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup