bugBattle for Wesnoth - Bugs: bug #22162, strange warnings in console about...

 
 
Show feedback again

bug #22162: strange warnings in console about unit attributes

Submitted by:  Chris Beck <involution>
Submitted on:  Sun 08 Jun 2014 04:43:34 PM UTC  
 
Category: BugSeverity: 2 - Minor
Priority: 4Item Group: Campaign
Status: ConfirmedPrivacy: Public
Assigned to: Andrius Silinskas <thunderstruck>Open/Closed: Open
Release: 1.13.0-devOperating System: Linux Mint 16

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 13 Jul 2014 02:06:33 PM UTC, comment #4:

i think neigher units nor sides have a 'persistence' attribute, so most lakike in this case the the error message shows exactly what teh error is: someone used an unknown attribute 'persistence' somewhere.

Anonymous
Tue 01 Jul 2014 04:32:56 PM UTC, comment #3:

Or maybe it's just supposed to go in here?
https://github.com/wesnoth/wesnoth/blob/master/src/multiplayer_connect_engine.cpp#L51

Chris Beck <involution>
Project Member
Tue 01 Jul 2014 02:53:37 PM UTC, comment #2:

I think the no_recruit part of this bug is from a flag of team used only internally by the FLG manager:

$ grep "no_recruit" -r src/
src/flg_manager.hpp: const bool has_no_recruits_;
src/flg_manager.cpp: has_no_recruits_(
src/flg_manager.cpp: side_["no_recruit"].to_bool()) &&
src/flg_manager.cpp: has_no_recruits_) {
src/flg_manager.cpp: if ((!side_["faction"].empty() || !has_no_recruits_) && faction_lock_) {
src/flg_manager.cpp: if (!has_no_recruits_) {
src/multiplayer_connect_engine.cpp: res["no_recruit"] = true;

I don't know what the purpose of this attribute is, but I think either it should be added to team.cpp in this list:
https://github.com/wesnoth/wesnoth/blob/master/src/team.cpp#L54

and perhaps made accessible to WML / savefiles, or it should be stripped out of the team config when the mp connect finishes. These little warnings are somewhat distracting if you are trying to debug something.

I don't know about the persistence part but I'd like to assign this part to thunderstruck if that's okay.

Chris Beck <involution>
Project Member
Mon 09 Jun 2014 10:43:24 PM UTC, comment #1:

i noticed this too.

Daniel <gfgtdf>
Project Member
Sun 08 Jun 2014 04:43:34 PM UTC, original submission:

I seem to get both of these in large numbers in any LoW scenario, maybe others, I have not tested extensively:

20140608 12:41:36 warning unit: Unknown attribute 'no_recruit' discarded.
20140608 12:41:36 warning unit: Unknown attribute 'persistence' discarded.

Chris Beck <involution>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gfgtdf (Posted a comment)
  • -unavailable- added by involution (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 01 Jul 2014 02:53:36 PM UTCinvolutionAssigned toNone=>thunderstruck
    Mon 09 Jun 2014 10:43:24 PM UTCgfgtdfStatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup