bugFreeciv - Bugs: bug #22170, SDL clients don't display veteran...

 
 
Show feedback again

bug #22170: SDL clients don't display veteran levels

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 10 Jun 2014 09:05:19 AM UTC  
 
Category: client-sdlSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: Operating System: None
Planned Release: 2.4.3, 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 21 Jun 2014 09:20:54 PM UTC, SVN revision 25217:

Show real veteran level names in sdl-clients

Reported by Jacob Nevins

See bug #22170

(Browse SVN revision 25217)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 21 Jun 2014 09:20:47 PM UTC, SVN revision 25216:

Show real veteran level names in sdl-clients

Reported by Jacob Nevins

See bug #22170

(Browse SVN revision 25216)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sat 21 Jun 2014 09:20:40 PM UTC, SVN revision 25215:

Show real veteran level names in sdl-clients

Reported by Jacob Nevins

See bug #22170

(Browse SVN revision 25215)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Thu 19 Jun 2014 12:57:02 AM UTC, comment #1:

Patch

There is slight downside to this simple implementation. The old code sometimes used "veteran" and sometimes "Veteran" (capital first letter). Now it's always what's given in the ruleset. We could use the "capitalize first letter of translation" here (currently supporting Finnish translation only), but is it worth it?

(file #21083, file #21084)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Tue 10 Jun 2014 09:05:19 AM UTC, original submission:

While looking for something else I noticed that the SDL code is full of

pUnit->veteran ? _("Veteran") : ""

It ought to be fairly easy to replace this with the name of the veteran level.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21083:  VeteranSdl.patch.bz2 added by cazfi (5kB - application/x-bzip)
file #21084:  VeteranSdl-S2_5.patch added by cazfi (13kB - text/x-diff)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 21 Jun 2014 09:21:25 PM UTCcazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Thu 19 Jun 2014 12:57:02 AM UTCcazfiAttached File-=>Added VeteranSdl.patch.bz2, #21083
      Attached File-=>Added VeteranSdl-S2_5.patch, #21084
      StatusNone=>Ready For Test
      Planned Release=>2.4.3, 2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup