bugBattle for Wesnoth - Bugs: bug #22173, check_victory broken inside draw.

 
 
Show feedback again

bug #22173: check_victory broken inside draw.

Submitted by:  Daniel <gfgtdf>
Submitted on:  Tue 10 Jun 2014 06:45:01 PM UTC  
 
Category: Feature RequestSeverity: 2 - Minor
Priority: 5 - NormalItem Group:  None of the others
Status: Wont FixPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: 1.13-devOperating System: win7

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 14 Sep 2014 06:15:36 PM UTC, comment #2:

Ok i am still not 100% sure, but i think that the wesnoth.teeme_items code takes place in a whitboard moves applied context makes sense in most times.

so i decreased importance and made https://gna.org/bugs/?22635 instead.

maybe we should make a check inside check_victory that warn if it's called from a "whiteboard applied context".

Daniel <gfgtdf>
Project Member
Fri 13 Jun 2014 11:34:08 PM UTC, comment #1:

this bug annoys me so much.. i upgraded its importance.

But note this this ismmost likley only annoying if you use [do_command] action wml which is a 1.13 only feature.

Daniel <gfgtdf>
Project Member
Tue 10 Jun 2014 06:45:01 PM UTC, original submission:

when check_vicotry in the case (the stackstrace) shown below, it wrongly calsulates that the current side has won, since this is only the case when fog is on i assume the reason is that gameboard_.units() only contains visible units in this case.

i ovserved this on version 03021c04828a87f389a93a437a516f7d1a5d2a8a (doesn't mean it's related on this commit)

Stacktrace:

Daniel <gfgtdf>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by gfgtdf (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 10 Nov 2014 03:15:15 AM UTCgfgtdfCategoryBug=>Feature Request
      StatusNone=>Wont Fix
      Open/ClosedOpen=>Closed
    Sun 14 Sep 2014 06:15:36 PM UTCgfgtdfSeverity4 - Important=>2 - Minor
    Fri 13 Jun 2014 11:34:08 PM UTCgfgtdfSeverity3 - Normal=>4 - Important
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup