bugBattle for Wesnoth - Bugs: bug #22173, check_victory broken inside draw.

Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #22173: check_victory broken inside draw.

Submitted by:  Daniel <gfgtdf>
Submitted on:  Tue Jun 10 18:45:01 2014  
Category: Feature RequestSeverity: 2 - Minor
Priority: 5 - NormalItem Group:  None of the others
Status: Wont FixPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: 1.13-devOperating System: win7

Sun Sep 14 18:15:36 2014, comment #2:

Ok i am still not 100% sure, but i think that the wesnoth.teeme_items code takes place in a whitboard moves applied context makes sense in most times.

so i decreased importance and made https://gna.org/bugs/?22635 instead.

maybe we should make a check inside check_victory that warn if it's called from a "whiteboard applied context".

Daniel <gfgtdf>
Project Member
Fri Jun 13 23:34:08 2014, comment #1:

this bug annoys me so much.. i upgraded its importance.

But note this this ismmost likley only annoying if you use [do_command] action wml which is a 1.13 only feature.

Daniel <gfgtdf>
Project Member
Tue Jun 10 18:45:01 2014, original submission:

when check_vicotry in the case (the stackstrace) shown below, it wrongly calsulates that the current side has won, since this is only the case when fog is on i assume the reason is that gameboard_.units() only contains visible units in this case.

i ovserved this on version 03021c04828a87f389a93a437a516f7d1a5d2a8a (doesn't mean it's related on this commit)


Daniel <gfgtdf>
Project Member


No files currently attached


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by gfgtdf (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Nov 10 03:15:15 2014gfgtdfCategoryBug=>Feature Request
      StatusNone=>Wont Fix
    Sun Sep 14 18:15:36 2014gfgtdfSeverity4 - Important=>2 - Minor
    Fri Jun 13 23:34:08 2014gfgtdfSeverity3 - Normal=>4 - Important
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup