bugFreeciv - Bugs: bug #22299, Server allows to move to transport...

 
 
Show feedback again

bug #22299: Server allows to move to transport tile even if it cannot load into

Submitted by:  pepeto <pepeto>
Submitted on:  Wed 09 Jul 2014 01:13:03 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: trunkOperating System: Any
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 19 Jul 2014 09:14:15 AM UTC, SVN revision 25619:

Really take in account embark/disembark restriction rules when moving. It was
resulting units standing on undesirable tiles. Prefer transport_from_tile()
to unit_class_transporter_capacity().

See gna bug #22299

(Browse SVN revision 25619)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 19 Jul 2014 09:14:09 AM UTC, SVN revision 25618:

Really take in account embark/disembark restriction rules when moving. It was
resulting units standing on undesirable tiles. Remove confusing
unit_class_transporter_capacity(), and prefer transport_from_tile().

See gna bug #22299

(Browse SVN revision 25618)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 12 Jul 2014 09:23:55 AM UTC, comment #1:

Fix attached for trunk: use transport_from_tile() instead of unit_class_transporter_capacity().

For S2_5, after applying the patch, only path-finding will be still affected. But the server will respect the rules.

For S2_4, it seems very more complicate. I strongly think it should stay how it works now, but we should drop any load/unload restriction.

(file #21368, file #21369)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 09 Jul 2014 01:13:03 PM UTC, original submission:

Noticed in bug #22050 and bug #22187, you can move to the tile, without loading to the transport. Then you can see land units alone in the middle of the ocean.

I think the main problem is that unit_move_to_tile_test() only check unit_class_transporter_capacity() instead of calling could_unit_load().

However, I didn't investigate deeper. Maybe they are other related problems. I suppose S2_4 and S2_5 are also affected, but I haven't check yet.

pepeto <pepeto>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 19 Jul 2014 09:14:29 AM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 19 Jul 2014 07:25:57 AM UTCpepetoAssigned toNone=>pepeto
    Sat 12 Jul 2014 09:23:55 AM UTCpepetoAttached File-=>Added trunk_remove_unit_class_transporter_capacity.patch, #21368
      Attached File-=>Added S2_5_prefer_transport_from_tile.patch, #21369
      StatusNone=>Ready For Test
      Planned Release=>2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup