bugFreeciv - Bugs: bug #22314, QT client strings unsuitable for...

 
 
Show feedback again

bug #22314: QT client strings unsuitable for i18n

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat 12 Jul 2014 12:36:29 PM UTC  
 
Category: client-qtSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: mir3x <mir3x>Open/Closed: Closed
Release: S2_5 r25502Operating System: Any
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 04 Sep 2014 09:28:29 AM UTC, SVN revision 26213:

Fixed strings in Qt-client unsuitable for i18n
bug reported by Jacob Nevins

See bug #22314

(Browse SVN revision 26213)

mir3x <mir3x>
Project MemberIn charge of this item.
Thu 04 Sep 2014 09:28:14 AM UTC, SVN revision 26212:

Fixed strings in Qt-client unsuitable for i18n
bug reported by Jacob Nevins

See bug #22314

(Browse SVN revision 26212)

mir3x <mir3x>
Project MemberIn charge of this item.
Tue 02 Sep 2014 06:53:46 PM UTC, comment #4:

Fixed big bunch of messages

(file #22001, file #22002)

mir3x <mir3x>
Project MemberIn charge of this item.
Thu 28 Aug 2014 05:40:20 PM UTC, comment #3:

ask.setText(PL_("Are you sure you want to disband that %1 unit?", "Are you sure you want to disband those %1 units?", unit_list_size(punits)));

Yes, unfortunately that means that in English text the count "1" is also spelled out and not left to be deducted from the fact that word "unit" is singular. But it makes it possible to provide any number of different plural forms in languages that don't have simple 1 = singular, "not 1" = plural, rules.

Marko Lindqvist <cazfi>
Project Administrator
Thu 28 Aug 2014 05:29:01 PM UTC, comment #2:

It should probably use PL_(). But I don't see how if the number of argument is not the same.

pepeto <pepeto>
Project Member
Thu 28 Aug 2014 03:27:54 PM UTC, comment #1:

Whats wrong in second case ? How it should be then ?

mir3x <mir3x>
Project MemberIn charge of this item.
Sat 12 Jul 2014 12:36:29 PM UTC, original submission:

I've noticed a number of constructs in the Qt client that aren't really suitable for i18n.

It probably wants a blanket review, ideally before too many translators spend time on the current strings.

1. Sentences assembled out of fragments by string concatenation rather than using format strings.

2. Non-generalised pluralisation.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #22001:  QtTranslation-S25.patch.bz2 added by mir3x (5kB - application/x-bzip)
file #22002:  QtTranslation-S26.patch.bz2 added by mir3x (5kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by mir3x (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 04 Sep 2014 09:29:21 AM UTCmir3xStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Tue 02 Sep 2014 06:53:46 PM UTCmir3xAttached File-=>Added QtTranslation-S25.patch.bz2, #22001
      Attached File-=>Added QtTranslation-S26.patch.bz2, #22002
      StatusNone=>Ready For Test
      Assigned toNone=>mir3x
      Planned Release=>2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup