bugFreeciv - Bugs: bug #22317, Path-finding unable to handle...

 
 
Show feedback again

bug #22317: Path-finding unable to handle recursive transports restrictions

Submitted by:  pepeto <pepeto>
Submitted on:  Sat 12 Jul 2014 02:57:31 PM UTC  
 
Category: aiSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: S2_5, trunkOperating System: Any
Planned Release: 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon 06 Oct 2014 10:10:12 PM UTC, comment #9:

> The main problem it that it will require a lot of work. I am
> not sure after patching the branch there won't be new bugs.

Fair enough. Let's not.
I assume the result of not fixing is just that client goto will claim that it's possible to enter/cross transports sometimes, when it isn't, and possibly that AI will make bad decisions in unlikely circumstances (but I guess it's unlikely to get completely stuck).

I leave closing the ticket to you.

Jacob Nevins <jtn>
Project Administrator
Sun 05 Oct 2014 08:31:21 PM UTC, comment #8:

> Well, why not? We've had lots of other pathfinding upheaval on
> S2_5 already since beta1, is this any more risky than the rest
> of it?


The main problem it that it will require a lot of work. I am not sure after patching the branch there won't be new bugs. trunk had changed a lot before this implementation.

> I gather we'd also want that fix on S2_5 if we took this one?


Sure.

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 05 Oct 2014 01:36:10 PM UTC, comment #7:

> Keeping open, in case someone would be interested to port it
> in S2_5 branch...

Well, why not? We've had lots of other pathfinding upheaval on S2_5 already since beta1, is this any more risky than the rest of it?

And 2.5.x is where recursive transport restrictions are first enforced.

> See also bug #22545.

I gather we'd also want that fix on S2_5 if we took this one?

Jacob Nevins <jtn>
Project Administrator
Sun 31 Aug 2014 01:36:57 PM UTC, comment #6:

See also bug #22545.

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 24 Jul 2014 05:26:47 PM UTC, comment #5:

Keeping open, in case someone would be interested to port it in S2_5 branch...

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 24 Jul 2014 05:25:44 PM UTC, SVN revision 25716:

Take in account recursive transport restriction rules in path-finding.

See gna bug #22317

(Browse SVN revision 25716)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 22 Jul 2014 05:03:19 PM UTC, comment #3:

Patch ready for trunk.

(file #21511)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 13 Jul 2014 05:07:29 PM UTC, comment #2:

Reading could_unit_load() in common/unit.c, the missing tests are:

  • unit_transport_check() ;
  • GAME_TRANSPORT_MAX_RECURSIVE.

(Amphibious path-finding is another problem. It is used to make paths for a transporter and its cargo, I doubt embarking is relevant in this case. I would like to replace it in version 3.0 to pf_combined_map or something like this, which will really fit the ruleset).

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 12 Jul 2014 03:06:26 PM UTC, comment #1:

Why? Isn't this handled inside unit_list_iterate(ptile->units, punit) in pf_move_scope? or is the problem that units fail to notionally load for amphibious pathfinding?

Emmet Hikory <persia>
Project Member
Sat 12 Jul 2014 02:57:31 PM UTC, original submission:

$subject

pepeto <pepeto>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Digest:
   bug dependencies, patch dependencies.

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by persia (Posted a comment)
  • -unavailable- added by pepeto (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 14 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 06 Oct 2014 11:09:50 PM UTCpepetoStatusNone=>Fixed
      Assigned toNone=>pepeto
      Open/ClosedOpen=>Closed
    Mon 06 Oct 2014 10:10:12 PM UTCjtnPlanned Release2.5.0, 2.6.0=>2.6.0
    Thu 24 Jul 2014 05:26:47 PM UTCpepetoStatusReady For Test=>None
      Assigned topepeto=>None
    Tue 22 Jul 2014 05:03:19 PM UTCpepetoAttached File-=>Added pf_recursive_transports_restrictions.patch, #21511
      StatusNone=>Ready For Test
      Operating SystemNone=>Any
    Tue 22 Jul 2014 05:02:36 PM UTCpepetoDependencies-=>Depends on patch #4973
    Sat 19 Jul 2014 09:19:11 AM UTCpepetoDependencies-=>Depends on bugs #22187
    Sat 19 Jul 2014 07:29:03 AM UTCpepetoCategoryNone=>ai
      Assigned toNone=>pepeto
    Sat 12 Jul 2014 03:01:34 PM UTCpepetoDependencies-=>bugs #22050 is dependent
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup