bugFreeciv - Bugs: bug #22347, helptext_building() ->...

 
 
Show feedback again

bug #22347: helptext_building() -> is_nation_pickable(): assertion '!is_server()' failed

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Tue 15 Jul 2014 04:43:06 AM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: S2_5, trunkOperating System: None
Planned Release: 2.5.0, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed 01 Oct 2014 06:26:14 PM UTC, SVN revision 26655:

List all nations in current nation set in the help dialog (not only the ones
which are pickable, e.g. if they have no start position). Do not list barbarians
nations which doesn't match the current nation set.

Reported by Jacob Nevins

See gna bug #22603

Side effect: remove assertion failures when running freeciv-manual.

Reported by Marko Lindqvist

See gna bug #22347

(Browse SVN revision 26655)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 01 Oct 2014 06:26:09 PM UTC, SVN revision 26654:

List all nations in current nation set in the help dialog (not only the ones
which are pickable, e.g. if they have no start position). Do not list barbarians
nations which doesn't match the current nation set.

Reported by Jacob Nevins

See gna bug #22603

Side effect: remove assertion failures when running freeciv-manual.

Reported by Marko Lindqvist

See gna bug #22347

(Browse SVN revision 26654)

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 24 Jul 2014 08:01:54 AM UTC, comment #2:

See also bug #22346.

pepeto <pepeto>
Project MemberIn charge of this item.
Thu 24 Jul 2014 07:59:15 AM UTC, comment #1:

Quick fixes attached.

This bug shows the limit of the is_server() model since we have multiplied freeciv tools.

(file #21531, file #21532)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 15 Jul 2014 04:43:06 AM UTC, original submission:

freeciv-manual spits out a lot of failed asserts when one tries to run it.

These seem to come from is_nation_pickable() called by helptext_building().

Marko Lindqvist <cazfi>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #21532:  S2_5_freeciv_manual.patch added by pepeto (717B - text/x-patch)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by cazfi (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 10 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 25 Oct 2014 03:13:23 PM UTCjtnDependencies-=>bugs #22796 is dependent
    Wed 01 Oct 2014 06:26:37 PM UTCpepetoStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Fri 26 Sep 2014 08:12:58 AM UTCpepetoStatusReady For Test=>In Progress
      Assigned toNone=>pepeto
    Thu 24 Jul 2014 07:59:15 AM UTCpepetoAttached File-=>Added trunk_freeciv_manual.patch, #21531
      Attached File-=>Added S2_5_freeciv_manual.patch, #21532
      StatusNone=>Ready For Test
      Release=>S2_5, trunk
      Planned Release=>2.5.0, 2.6.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup