bugsubtitleeditor - Bugs: bug #22482, Another regression of gtk3 port

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #22482: Another regression of gtk3 port

Submitted by:  Tomáš Hnyk <sup>
Submitted on:  Sat 16 Aug 2014 12:09:54 PM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Confirmed
Privacy: PublicAssigned to: kitone <kitone>
Open/Closed: Open

(Jump to the original submission Jump to the original submission)

Sun 12 Apr 2015 06:06:37 PM UTC, comment #11:

Still an issue, so marking as confirmed.

Tomáš Hnyk <sup>
Project Member
Mon 05 Jan 2015 11:49:12 PM UTC, comment #10:

That compiles but does not help. I use 1.0.10, the latest release (self-compiled).

Tomáš Hnyk <sup>
Project Member
Mon 05 Jan 2015 11:34:49 PM UTC, comment #9:

ok, if you replace with this two lines :

m_editable->set_left_margin(property_xpad());
m_editable->set_right_margin(property_xpad());

what is your gtkmm version ?

kitone <kitone>
Project AdministratorIn charge of this item.
Mon 05 Jan 2015 11:25:05 PM UTC, comment #8:

Hm, it fails in compilation (I tried make clean but it still fails) with:

subtitleview.cc: In constructor 'TimeCell::TimeCell()':
subtitleview.cc:46:57: warning: base 'Gtk::CellEditable' will be initialized after [-Wreorder]
:Gtk::CellEditable(), Glib::ObjectBase(typeid(TimeCell))
^
subtitleview.cc:46:57: warning: base 'Glib::ObjectBase' [-Wreorder]
subtitleview.cc:45:2: warning: when initialized here [-Wreorder]
TimeCell()
^
In file included from /usr/include/glibmm-2.4/glibmm/exception.h:25:0,
from /usr/include/glibmm-2.4/glibmm/error.h:23,
from /usr/include/glibmm-2.4/glibmm/thread.h:56,
from /usr/include/glibmm-2.4/glibmm.h:87,
from cfg.h:27,
from subtitleview.cc:27:
/usr/include/glibmm-2.4/glibmm/ustring.h: In instantiation of 'static Glib::ustring Glib::ustring::compose(const Glib::ustring&, const T1&, const T2&) [with T1 = Glib::ustring; T2 = Glib::ustring]':
subtitleview.cc:560:147: required from here
/usr/include/glibmm-2.4/glibmm/ustring.h:1354:61: warning: conversion to 'int' from 'long unsigned int' may alter its value [-Wconversion]
return ustring::compose_argv(fmt, G_N_ELEMENTS(argv), argv);
^
In file included from subtitleview.cc:36:0:
gui/cellrenderercustom.h: In instantiation of 'Gtk::CellEditable* CellRendererCustom<T>::start_editing_vfunc(GdkEvent*, Gtk::Widget&, const Glib::ustring&, const Gdk::Rectangle&, const Gdk::Rectangle&, Gtk::CellRendererState) [with T = TextViewCell; GdkEvent = _GdkEvent]':
subtitleview.cc:1638:1: required from here
gui/cellrenderercustom.h:107:2: error: 'class TextViewCell' has no member named 'set_margin_start'
m_editable->set_margin_start(property_xpad());
^
gui/cellrenderercustom.h:108:2: error: 'class TextViewCell' has no member named 'set_margin_end'
m_editable->set_margin_end(property_xpad());
^
gui/cellrenderercustom.h: In instantiation of 'Gtk::CellEditable* CellRendererCustom<T>::start_editing_vfunc(GdkEvent*, Gtk::Widget&, const Glib::ustring&, const Gdk::Rectangle&, const Gdk::Rectangle&, Gtk::CellRendererState) [with T = TimeCell; GdkEvent = _GdkEvent]':
subtitleview.cc:1638:1: required from here
gui/cellrenderercustom.h:107:2: error: 'class TimeCell' has no member named 'set_margin_start'
m_editable->set_margin_start(property_xpad());
^
gui/cellrenderercustom.h:108:2: error: 'class TimeCell' has no member named 'set_margin_end'
m_editable->set_margin_end(property_xpad());
^

Tomáš Hnyk <sup>
Project Member
Mon 05 Jan 2015 11:15:53 PM UTC, comment #7:

Can you try this patch please.

(file #23415)

kitone <kitone>
Project AdministratorIn charge of this item.
Mon 05 Jan 2015 11:05:59 PM UTC, comment #6:

BTW: if the number updated automatically as per https://gna.org/bugs/?18985 - that would be great too:-).

Tomáš Hnyk <sup>
Project Member
Mon 05 Jan 2015 10:12:20 PM UTC, comment #5:

No, that still behaves the same with Adawaita (only in blue:-)).

Tomáš Hnyk <sup>
Project Member
Mon 05 Jan 2015 10:11:09 PM UTC, comment #4:

Adwaita theme.

If you change your ?

kitone <kitone>
Project AdministratorIn charge of this item.
Mon 05 Jan 2015 09:55:51 PM UTC, comment #3:

Hm, what theme are you using? I can still reproduce it. See for yourself here: https://www.youtube.com/watch?v=xNb6OZ4nYhA&feature=youtu.be

The waveform issue is fixed, thanks!

Tomáš Hnyk <sup>
Project Member
Mon 05 Jan 2015 07:52:05 PM UTC, comment #2:

I cannot reproduce this bug.

The last commit should fix the waveform issue.

kitone <kitone>
Project AdministratorIn charge of this item.
Mon 05 Jan 2015 07:51:26 PM UTC, SVN revision 880:

Fix bug #22482 : Another regression of gtk3 port (waveform issue).

(Browse SVN revision 880)

kitone <kitone>
Project AdministratorIn charge of this item.
Sat 16 Aug 2014 12:09:54 PM UTC, original submission:

In the text field, the length in characters of each line of subtitles is shown on the right. When editing any line, this number gets hidden. This used not to be the case.

(how to reproduce:
1. open a new file
2. insert one subtitle and write somethign to it
3. Notice the lentgh of the line on the right.
4. Edit the subtitle again
5. Notice that the lentgh dissappeared.)

(Also, closing waveform also unsets view>waveform, i.e. the widget with waveform closes. It seems weird to me, is that intentional? Should I file a separate bug about it if it is a bug?)

Tomáš Hnyk <sup>
Project Member

 

Attached Files

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -unavailable- added by kitone (Posted a comment)
  • -unavailable- added by sup (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 13 Apr 2015 11:37:54 AM UTCsupDependencies-=>bugs #18985 is dependent
    Sun 12 Apr 2015 06:06:37 PM UTCsupStatusReady For Test=>Confirmed
    Mon 05 Jan 2015 11:15:53 PM UTCkitoneAttached File-=>Added fix-bug-22482-textview-size.patch, #23415
      StatusFixed=>Ready For Test
    Mon 05 Jan 2015 07:52:05 PM UTCkitoneStatusNone=>Fixed
      Assigned toNone=>kitone
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup