bugBattle for Wesnoth - Bugs: bug #22487, Advanced preference description...

 
 
Show feedback again

bug #22487: Advanced preference description not showing up

Submitted by:  Lari Nieminen <zookeeper>
Submitted on:  Sat 16 Aug 2014 08:11:55 PM UTC  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: User Interface
Status: FixedPrivacy: Public
Assigned to: NoneOpen/Closed: Closed
Release: 1.11.16Operating System: win 7

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 13 Sep 2014 07:15:45 PM UTC, comment #1:

The problem was, it turns out that process_event() isn't responsible for displaying tooltips, there's instead a separate tooltips manager that also handles themes etc. Tooltips have to be registered when a ui object is created, in this case when the adv. preferences menu is being populated. For some reason we were always using the 'name' attribute there instead of 'description'.

1.12:
https://github.com/wesnoth/wesnoth/commit/29cc5bf7d2ef7562751859b24d6659b058dafd0f

master:
https://github.com/wesnoth/wesnoth/commit/58c135e49e70c9431c8cae15dd1ed9bc158e39bf

Chris Beck <involution>
Project Member
Sat 16 Aug 2014 08:11:55 PM UTC, original submission:

In the advanced preferences, the help text at the bottom of the screen repeats the name of the hovered-over preference, whereas it should display its description instead.

The name and description parsing code in preferences_dialog::process_event() looks correct, however.

Lari Nieminen <zookeeper>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by shadowmaster (Updated the item)
  • -unavailable- added by involution (Posted a comment)
  • -unavailable- added by zookeeper (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 12 Oct 2014 12:27:45 PM UTCshadowmasterOpen/ClosedOpen=>Closed
    Sat 13 Sep 2014 07:15:45 PM UTCinvolutionStatusNone=>Fixed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup