bugsubtitleeditor - Bugs: bug #22488, Regression in spellchecker

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #22488: Regression in spellchecker

Submitted by:  Tomáš Hnyk <sup>
Submitted on:  Sun 17 Aug 2014 09:07:17 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: kitone <kitone>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Sat 03 Jan 2015 09:22:47 PM UTC, comment #10:

Great, thanks, it works like a charm! The follow-up bug is here: https://gna.org/bugs/index.php?23139

Tomáš Hnyk <sup>
Project Member
Sat 03 Jan 2015 08:31:28 PM UTC, comment #9:

The last commit should fix this bug.

- Fix dialog
- Enter key on replace entry
- double click on suggestions

About the replace all, please open a new bug.

kitone <kitone>
Project AdministratorIn charge of this item.
Sat 03 Jan 2015 08:29:32 PM UTC, SVN revision 878:

Fix bug #22488 : Regression in spellchecker.

(Browse SVN revision 878)

kitone <kitone>
Project AdministratorIn charge of this item.
Sat 03 Jan 2015 07:29:53 PM UTC, comment #7:

Yes, this works great. View manager now works as well (regarding comment #2.

There is still issue mentioned in comment #3 (when entering something into a "replace with field", I would expect pressing enter to be equivavlent to clicking on the "replace button"). The same go for selecting a sugesstion with mouse - double clicking and enter should in my opinion have the same effect.

("replace all" mentioned in comment #1 would be nice too)

Tomáš Hnyk <sup>
Project Member
Sat 03 Jan 2015 05:44:01 PM UTC, comment #6:

Okay, remove the old patched file, svn update to restore then apply the v2 patch.

Is this better ?

(file #23369)

kitone <kitone>
Project AdministratorIn charge of this item.
Sat 03 Jan 2015 04:40:54 PM UTC, comment #5:

Hm, not quite. The area with suggestions grows but not enough (adn the close button gets to the middle of the window). See screenshot attached.

(file #23367)

Tomáš Hnyk <sup>
Project Member
Sat 03 Jan 2015 04:08:33 PM UTC, comment #4:

This patch should restore the default behaviour of spellchecker.

(file #23365)

kitone <kitone>
Project AdministratorIn charge of this item.
Sun 17 Aug 2014 12:13:51 PM UTC, comment #3:

Also, when typing in the field "replace with" or selecting a suggestion, "enter" should press "replace".

Tomáš Hnyk <sup>
Project Member
Sun 17 Aug 2014 10:03:43 AM UTC, comment #2:

BTW: the view manager has the same problem (if you have more then four views, the fifth is half-hidden even though the window is large enough for the widget.

Tomáš Hnyk <sup>
Project Member
Sun 17 Aug 2014 09:46:19 AM UTC, comment #1:

Also, if there were button that would "Replace all" certain mistakes (like "teh" to "the" in all document), that would sometimes simplify matters.

Tomáš Hnyk <sup>
Project Member
Sun 17 Aug 2014 09:07:17 AM UTC, original submission:

The field with suggestions in Spellchecking does not get enlarged with the window (see screenshots). That did no use to be the case with gtk2.

Tomáš Hnyk <sup>
Project Member

 

Attached Files
file #23367:  09.png added by sup (40kB - image/png - gtk3_with_patch_applied)
file #21753:  gtk2.png added by sup (30kB - image/png)
file #21754:  gtk3.png added by sup (38kB - image/png)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kitone (Updated the item)
  • -unavailable- added by sup (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 03 Jan 2015 08:31:28 PM UTCkitoneStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sat 03 Jan 2015 05:44:01 PM UTCkitoneAttached File-=>Added fix-bug-22488-regression-in-spellchecker-v2.patch, #23369
    Sat 03 Jan 2015 04:40:54 PM UTCsupAttached File-=>Added 09.png, #23367
    Sat 03 Jan 2015 04:08:33 PM UTCkitoneAttached File-=>Added fix-bug-22488-regression-in-spellchecker.patch, #23365
      StatusNone=>Ready For Test
      Assigned toNone=>kitone
    Sun 17 Aug 2014 09:07:17 AM UTCsupAttached File-=>Added gtk2.png, #21753
      Attached File-=>Added gtk3.png, #21754
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup