bugsubtitleeditor - Bugs: bug #22489, Text correction does not remember...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #22489: Text correction does not remember which corrections to apply

Submitted by:  Tomáš Hnyk <sup>
Submitted on:  Sun 17 Aug 2014 09:22:33 AM UTC  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Privacy: PublicAssigned to: kitone <kitone>
Open/Closed: Closed

(Jump to the original submission Jump to the original submission)

Sun 12 Apr 2015 12:13:14 PM UTC, comment #17:

The follow up bug: https://gna.org/bugs/index.php?23158
closing this one then.

Tomáš Hnyk <sup>
Project Member
Fri 09 Jan 2015 08:36:40 PM UTC, comment #16:

Maybe we can close this one, open a new bug about default focus for another day.

kitone <kitone>
Project AdministratorIn charge of this item.
Fri 09 Jan 2015 08:28:44 PM UTC, comment #15:

Hm, somehow the inside of the page 2&3 must be grabbing focus.

Well, gnome guys. I used to like them in GTK2 days, but now...

Anyway, I guess this is enough for me (even though the focus on ok/apply would be great, then it would be just F6>ENter>enter>enter and no mouse involved).

Tomáš Hnyk <sup>
Project Member
Fri 09 Jan 2015 08:20:21 PM UTC, comment #14:

Yes, I see this code too, don't now why the page grab focus.

This is natural Gtk (or a Gnome guy remove a button :)
https://developer.gnome.org/gtk3/stable/GtkAssistant.html#GtkAssistantPageType

kitone <kitone>
Project AdministratorIn charge of this item.
Fri 09 Jan 2015 08:07:12 PM UTC, comment #13:

Good, it keeps getting better:-) (and I just discovered there are lots of autocorrections when I select latin script, I had no idea, I will be using that from now on:-)).

In the last window when there are no changes. "Ok" button is great, but should not there be a back button as well?

As for the focus, it is weird, I found this message: https://mail.gnome.org/archives/commits-list/2009-July/msg04256.html

and judging by the code (I am no C coder though), it seems it tries to focus apply, close, forward, back, cancel and defaults to last (whatever hat is): https://github.com/linuxmint/gtk/blob/master/gtk/gtkassistant.c#L777 - I have no idea why it does not work like that in this case.

Tomáš Hnyk <sup>
Project Member
Fri 09 Jan 2015 07:44:09 PM UTC, comment #12:

I know how to set focus, but I cannot acces to GtkAssitant buttons without making my own buttons, not sure it's a good idea.

kitone <kitone>
Project AdministratorIn charge of this item.
Fri 09 Jan 2015 07:41:00 PM UTC, comment #11:

Two last commit should fix:
- The configuration save on close, cancel and apply
- Without change, display close button

kitone <kitone>
Project AdministratorIn charge of this item.
Fri 09 Jan 2015 07:35:23 PM UTC, SVN revision 886:

Fix bug #22489 : Text correction - save the config, on close, save and cancel.

(Browse SVN revision 886)

kitone <kitone>
Project AdministratorIn charge of this item.
Fri 09 Jan 2015 07:25:02 PM UTC, SVN revision 885:

Fix bug #22489 : Text correction - Fix error introduce with the previous commit and only display close button without errors.

(Browse SVN revision 885)

kitone <kitone>
Project AdministratorIn charge of this item.
Fri 09 Jan 2015 03:00:40 AM UTC, comment #8:

Great, the double click and remembering the check is great. Thanks.

It actually remembers only when some errors are made and one can click "apply" - if no corrections are found, one must press click and the changes to checklists are forgotten. But this is very minor - as I say, I just need to set it once and never change it again.

As per the focus, would not this help? http://stackoverflow.com/questions/8728172/gtk-set-default-button-for-dialog
(this is for changing the buttons labels dynamically: http://stackoverflow.com/questions/2779664/change-the-label-of-gtkbutton ).

Tomáš Hnyk <sup>
Project Member
Thu 08 Jan 2015 10:44:52 PM UTC, comment #7:

The last two commit should fix the double click wish.

About the focus, I don't know how to do this...

kitone <kitone>
Project AdministratorIn charge of this item.
Thu 08 Jan 2015 10:43:17 PM UTC, SVN revision 884:

Fix bug #22489 : Text correction - ability to double click on confirmation page.

(Browse SVN revision 884)

kitone <kitone>
Project AdministratorIn charge of this item.
Thu 08 Jan 2015 10:36:05 PM UTC, SVN revision 883:

Fix bug #22489 : Text correction - ability to double click to swith enable status.

(Browse SVN revision 883)

kitone <kitone>
Project AdministratorIn charge of this item.
Thu 08 Jan 2015 10:22:38 PM UTC, comment #4:

Last commit should correct the remember.

kitone <kitone>
Project AdministratorIn charge of this item.
Thu 08 Jan 2015 10:21:27 PM UTC, SVN revision 882:

Fix bug #22489 : Text correction does not remember which corrections to apply.

(Browse SVN revision 882)

kitone <kitone>
Project AdministratorIn charge of this item.
Sun 17 Aug 2014 11:35:34 AM UTC, comment #2:

Also, one should be able to doubble click not just on the ticker but on the name and description of the correction too (so that all the highlighted area would toggle that correction).

Tomáš Hnyk <sup>
Project Member
Sun 17 Aug 2014 09:41:28 AM UTC, comment #1:

Also, the focus after launching the tool should be on ok, so one would just need to press enter to go to the next stage (and then again). I think the prevailing use case is that one uses the same corrections over and over and does not change the checkboxes on each run.

Also, in the last step, if there are no corrections made, "apply" is greyed out - either fofuc "cancel" or dynamically change "apply" to "ok" and focus that. Focusing the field with not changes in it seems useless.

I would also welcome if apply were focused in the third step even with some corrections to be made, I always accept them all.

Tomáš Hnyk <sup>
Project Member
Sun 17 Aug 2014 09:22:33 AM UTC, original submission:

The Text correction tool always starts with all possibilities unchecked. In GTK2, it started with "Correct common errors" checked. Ideally, i could remember what was checked the last time it was used.

Tomáš Hnyk <sup>
Project Member

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by kitone (Posted a comment)
  • -unavailable- added by sup (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 12 Apr 2015 12:13:14 PM UTCsupOpen/ClosedOpen=>Closed
    Fri 09 Jan 2015 09:05:35 PM UTCsupStatusReady For Test=>Fixed
    Thu 08 Jan 2015 10:22:38 PM UTCkitoneStatusNone=>Ready For Test
      Assigned toNone=>kitone
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup