bugFreeciv - Bugs: bug #22562, Server segfault in fair island map...

 
 
Show feedback again

bug #22562: Server segfault in fair island map generator

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Tue 02 Sep 2014 09:14:32 PM UTC  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: Operating System: GNU/Linux
Planned Release: 2.5.0-beta2, 2.6.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Fri 05 Sep 2014 07:30:33 AM UTC, SVN revision 26219:

Fair island map generator: added checks for map borders to avoid segfaults.

Also added some assertions and simplified how sea is made arround the islands.

Reported by Jacobs Nevins

See gna bug #22562

(Browse SVN revision 26219)

pepeto <pepeto>
Project MemberIn charge of this item.
Fri 05 Sep 2014 07:30:29 AM UTC, SVN revision 26218:

Fair island map generator: added checks for map borders to avoid segfaults.

Also added some assertions and simplified how sea is made arround the islands.

Reported by Jacobs Nevins

See gna bug #22562

(Browse SVN revision 26218)

pepeto <pepeto>
Project MemberIn charge of this item.
Wed 03 Sep 2014 11:55:13 AM UTC, comment #1:

The problem was that the land is created outside the map (with non-wrapping proprieties), and the returned value of fair_map_tile_step() was not always checked.

Fix attached: added checks for map borders + some assertions + simplification of sea making around the island.

(file #22006)

pepeto <pepeto>
Project MemberIn charge of this item.
Tue 02 Sep 2014 09:14:32 PM UTC, original submission:

S2_5 r26195. Started a standalone server with

and got a segfault on starting the game:

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Updated the item)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 05 Sep 2014 07:30:44 AM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Wed 03 Sep 2014 11:55:13 AM UTCpepetoAttached File-=>Added fair_island_gen_border.patch, #22006
      StatusIn Progress=>Ready For Test
    Wed 03 Sep 2014 07:21:00 AM UTCpepetoCategoryNone=>general
      StatusNone=>In Progress
      Assigned toNone=>pepeto
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup