bugFreeciv - Bugs: bug #24080, Include packet/field name in...

 
 
Show feedback again

bug #24080: Include packet/field name in "Trying to put X into Y bits" messages?

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun Nov 15 12:30:22 2015  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue Jun 14 20:00:28 2016, comment #3:

> The maximal number of fragments is 15


What version you had this with? It sounds like a bug #24074, but that was fixed in 2.5.2 already.

Replies to bug #24654, please.

Marko Lindqvist <cazfi>
Project Administrator
Mon May 9 23:19:51 2016, comment #2:

> The maximal number of fragments is 15


-> bug #24654

Marko Lindqvist <cazfi>
Project Administrator
Thu Mar 31 20:09:15 2016, comment #1:

Remotely related observation: The maximal number of fragments is 15, otherwise I get a loud bang and error messages telling me that X * 16 doesn't fit into 8 bits for 15 < X. (I wanted 100 fragments to get percent ;-)

Frank <dunnoob>
Sun Nov 15 12:30:22 2015, original submission:

When we get a message like

reported from a non-debug build, the first thing we usually want to know is which packet and field it's talking about.
(Debug builds output a backtrace which helps a lot, but that's no good for reports from real games.)

It would be possible for the invocations of DIO_PUT() from packets_gen.c to pass string representations of the packet and field names, to put in the message in case of failure. (Other invocations of the dio_put family of functions could be made to pass NULL, through wrappers.)

However, I don't know if the extra pointer parameter passing would significantly impact performance. Also all the field names would end up in the binary (if they're not there already; packet names are, in packet_name9)).

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by dunnoob (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup