bugFreeciv - Bugs: bug #24363, Crash on "Map topology and...

 
 
Show feedback again

bug #24363: Crash on "Map topology and tileset incompatible" during running game

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat Jan 30 20:22:30 2016  
 
Category: client-gtk-2.0Severity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: trunk r31681Operating System: GNU/Linux
Planned Release: 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat Jan 30 21:21:17 2016, comment #3:

> Is it now necessary to switch to a ts topology that does not
> match map topology?

I'm usually running into it when making a change to all tilesets and wanting to cycle through them all without starting a new game. This obviously isn't a real use case.

Someone might run into it for the sort of reasons given in bug #24145; I know at least one person who'd play an iso scenario with trident tiles rather than an iso tileset, and they might get caught out by the default preference (when we fix it) and try to change at runtime.

Jacob Nevins <jtn>
Project Administrator
Sat Jan 30 21:06:26 2016, comment #2:

Is it now necessary to switch to a ts topology that does not match map topology? Idle loop stuff has proven troublesome in gtk3-client several times already (I think we gained some fundamental problem in gtk2 -> gtk3, maybe because now gtk has habit to queue drawing requests instead of drawing immediately)

Marko Lindqvist <cazfi>
Project Administrator
Sat Jan 30 20:34:40 2016, comment #1:

> Could the fix be as simple as moving the error later in
> tilespec_reread(), when loading has basically finished?

Moving it to just before the C_S_RUNNING bailout doesn't stop the crash.

Jacob Nevins <jtn>
Project Administrator
Sat Jan 30 20:22:30 2016, original submission:

If, once connected to a running game, I change the tileset to one that doesn't match the game topology, the Gtk2 and Gtk3 clients at least reliably crash.

Looks like the message is popped up halfway through tileset setup, and the Gtk idle loop goes ahead with redraws with that half-setup tileset?

Could the fix be as simple as moving the error later in tilespec_reread(), when loading has basically finished?

(IIRC this happens with S2_6 too, but I haven't double-checked.)

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup