bugFreeciv - Bugs: bug #24389, Climate moderation at coasts not...

 
 
Show feedback again

bug #24389: Climate moderation at coasts not working as intended

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat Feb 6 10:44:27 2016  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: Any
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Wed Feb 10 00:35:43 2016, comment #3:

(patch now available at patch #6944)

1. Sure, but the reason I hesitated is that this code has never been in use, so should be treated like new code; i.e. we should check if it gives a sensible result before fixing the bug. (I haven't tried it and seen what the resulting maps look like.)
Also I wasn't sure how it would interact with my sea ice stuff (now taking shape in patch #6921).

2. (procedural) It's OK (indeed, preferred) to submit patches for bugs under the bug ticket (this one); you don't need to create a separate patch ticket for the fix. We use Gna's "bug" and "patch" tickets approximately for "bugs" and "features", and .patch files go under both. All revisions of a patch go under the same ticket until it's finally committed.

Jacob Nevins <jtn>
Project Administrator
Sun Feb 7 06:12:01 2016, comment #2:

I think this just may need some typecasting to float:

float temperate = (0.15 * ((float)game.map.server.temperature / 100 - (float)t

Robert Finch <robfinch>
Sat Feb 6 13:37:31 2016, comment #1:

Recently, I had a game with a greater number of smaller islands, where the coastline was not even.

When global heating set in, the coast got abridged and islands cutted through so fast, that the game became no more playable with fun. This happened wIthin a small number of turns.

Yes, I think its too much and too fast.

Since that I play always with global heating set off.

Christian

Christian Knoke <chrisk>
Project Member
Sat Feb 6 10:44:27 2016, original submission:

In create_tmap there's code intended to make ocean proximity moderate climate extremes:

However, since the core term

is all in integer arithmetic (all variables are 'int'), I think this can't be working as designed; the whole term is either 1, 0, or -1:

  • For temperature<100, this term has no effect except for perhaps a few tiles exactly at the equator getting colder
  • For temperature==100, tiles near water get warmer everywhere except exactly at the equator

I think this can never have worked since the code was added in (I think) r8213 in 2004.

I haven't tested this.

I'm looking at making it possible for the map generator to generate sea ice, so I'd want to think a bit about how to fix this (since it affects the temperature of water tiles).

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by robfinch (Posted a comment)
  • -unavailable- added by chrisk (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup