bugFreeciv - Bugs: bug #24467, server crash/quit? with ruleset...

 
 
Show feedback again

bug #24467: server crash/quit? with ruleset with city vision 0?

Submitted by:  Frank <dunnoob>
Submitted on:  Thu Feb 25 23:03:52 2016  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: 2.5.1Operating System: None
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu Jul 28 23:20:02 2016, comment #2:

Based on the date (Feb 25) it was a predecessor of the ruleset in the ZIP attached to bug #24536 (Feb 29), but did not work for the reasons stated here, i.e., init_vis_radius_sq and init_city_radius_sq behave differently (one is required even if the radius is otherwise determined in the effects, while the other is redundant if the radius is determined in the effects.)

If you haven't the faintest what I'm talking about holler, I could try to find it in the code.

Frank <dunnoob>
Sun Jul 10 13:30:17 2016, comment #1:

> 1: in set_socket_errno() [../../../../utility/netintf.c::91]: Missing errno mapping for Winsock error #10053.

I think this is the real error (10053 = WSAECONNABORTED = connection closed rudely); I'm guessing the server crashed or otherwise died...

> 3: in get_packet_from_connection() [../../../../common/packets.c::440]: Uncompressing of the packet stream failed. The connection will be closed now.
> 1: in client_conn_close_callback() [../../../../client/clinet.c::144]: Lost connection to server: decoding error.

...and I'm guessing these are just knock-on effects from that (client got half a compressed packet, or whatever).

It would be useful to see the actual ruleset files that provoked this.

Jacob Nevins <jtn>
Project Administrator
Thu Feb 25 23:03:52 2016, original submission:

2.5.1 server "decoding error", see the attached decoding logfile.

Background: The experimental ruleset has four city radius effects
with corresponding city vision effects. I adopted this in smaller
steps 4 (2,0), 5 (2,1), 8 (2,2), 9 (3,0), etc.; instead of bigger
jumps 2 (1,1), 5 (2,1), 10 (3,1), 17 (4,1).

Minor nit, for radius > vision the invisible tiles are additionally
unworkable, that should be documented somewhere. I now always have
radius < vision in seven steps up to 16 (4,0) < 17 (4,1).

The experimental ruleset has an initial "vision 0" effect (value 2)
and a game.ruleset init_vis_radius_sq (value 5). On the other hand
it has no initial "radius 0" for the similar init_city_radius_sq.

In my version I started at "radius 2" (value 1) and got 4 + 1 = 5
for init_city_radius_sq 4. Then I tested to start with "vision 2"
(value 3) expecting 5 + 3 = 8 for init_vis_radius_sq 5.

At that point I got the unclear "decoding error" for a save game
with an explicit "vision 0". Wild guess: init_city_radius_sq does
what its name says, and initializes City_Radius_Sq. The similar
init_vis_radius_sq does NOT initialize City_Vision_Radius_Sq.

IMO this can't be as it should be, either city radius should work
like the city vision, or city vision should work like the radius.

CAVEAT, city radius (4,1) with vision (3,3) would not work, the
smaller radius sqrt(17) for (4,1) covers more iso tiles than the
bigger radius sqrt(18) for (3,3), shown on Wiki page [[Radius]].

Frank <dunnoob>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #26863:  decoding error.log added by dunnoob (174kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by cazfi (Updated the item)
  • -unavailable- added by dunnoob (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Jul 10 13:27:10 2016jtnSummarydecoding error=>server crash/quit? with ruleset with city vision 0?
    Fri Feb 26 07:09:28 2016cazfiRelease=>2.5.1
    Thu Feb 25 23:04:39 2016dunnoobAttached File-=>Added decoding error.log, #26863
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup