bugFreeciv - Bugs: bug #24470, Server settings in client rc file...

 
 
Show feedback again

bug #24470: Server settings in client rc file not migrated between versions

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sat Feb 27 17:25:21 2016  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Feb 29 22:47:04 2016, comment #1:

Setting 3.0.0 as target to make sure we check this in 3.0 cycle at latest (it appears in searches of 3.0 targeted tickets). Backporting to S2_6 is something to consider when we have at least plans how this is be made.

Marko Lindqvist <cazfi>
Project Administrator
Sat Feb 27 17:25:21 2016, original submission:

We've got machinery in savecompat.c to migrate server settings in old savegames to equivalent values for the current server.

There's no such machinery for old server settings in old client rc files, so they are ignored or lost.
(Except for settable_option_upgrade_value() and allow_digital_boolean, which do some 2.2->2.3 stuff.)

So for instance a .freeciv-client-rc-2.4 which has killcitizen="SEA" will not result in a .freeciv-client-rc-2.5 with killcitizen=FALSE, as it would in a savegame.

Maybe we should pool the migration logic in common/ somewhere.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon Feb 29 22:47:04 2016cazfiCategoryNone=>general
      Planned Release=>3.0.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup