bugFreeciv - Bugs: bug #24842, Client should try harder to change...

 
 
Show feedback again

bug #24842: Client should try harder to change server topology when tileset forced with "-t"?

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun Jul 10 09:05:33 2016  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: Operating System: None
Planned Release: 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun Jul 10 09:05:33 2016, original submission:

In my experience at the moment on S2_6/trunk, starting the client with a forced tileset ("-t") does not cause the resulting game to have the topology of the tileset.

There's longstanding code in client_start_server() which attempts to do this. I haven't looked into why it isn't taking effect, but I could believe that saved client-side server settings and ruleset preferences could both override this very early setting.

I think that if a typical user has specified "-t tileset" on the command line, they'd expect to get a game matching that topology. So I think we should probably try harder to set it -- set the topology whenever the ruleset changes, etc. Not sure how to resolve conflict between "-t" and previously user-saved topology ID -- probably "-t" should override.

It is still useful for development purposes to allow the tileset and topology to mismatch; this can be achieved by "/set topology" on the chatline after the client has started its server, and probably by doing the same in the client UI. A naive user blundering into this will at least get a warning when they start the game so the ensuing weirdness should not be completely unexpected. (It will not be possible to encounter this without using "-t" on command-line.)

Similarly, when "-t" isn't specified, that code in client_start_server() should never run in the post bug #16668 world.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup