bugFreeciv - Bugs: bug #25120, Inconsistency in ownership rules...

 
 
Show feedback again

bug #25120: Inconsistency in ownership rules when creating bases

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun Sep 25 11:00:28 2016  
 
Category: NoneSeverity: 3 - Normal
Priority: 5 - NormalStatus: Need Info
Assigned to: NoneOpen/Closed: Open
Release: S2_6 r33879Operating System: None
Planned Release: 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun Sep 25 12:21:06 2016, comment #4:

That it works "as specified" in S2_6 does not mean we shouldn't improve ruleset options in TRUNK. At minimum we should add global option controlling how these things behave, maybe extra-specific option.

Marko Lindqvist <cazfi>
Project Administrator
Sun Sep 25 11:52:36 2016, comment #3:

OK. I suppose if ruleset authors don't like it their option is to prevent such bases coexisting with cities at all.

Jacob Nevins <jtn>
Project Administrator
Sun Sep 25 11:27:54 2016, comment #2:

Sorry for the noise. The final version was made with the idea that "latest action" determines extra owner - and building a city to the tile is one of such actions.

Marko Lindqvist <cazfi>
Project Administrator
Sun Sep 25 11:20:36 2016, comment #1:

Yes, the intent has been that extras in city tile are always owned by the city owner.

Marko Lindqvist <cazfi>
Project Administrator
Sun Sep 25 11:00:28 2016, original submission:

(This is all from reading code, none of it is tested.)

Currently, I think the ownership rules for extras that don't grant borders but have a useful owner (i.e. vision-granting bases like buoys) are:

  • When created, are owned by the owner of the building unit
  • Change hands if any other base is built on the same tile by a foreign unit
  • Change hands if a city is built on the same tile by a foreign unit (map_claim_ownership() with claim_bases==TRUE), if it doesn't destroy the base

and otherwise they do not change owner (even if the tile is occupied by an enemy unit).

I think there's an inconsistency here: building a city over a vision-granting base will claim it, but a building a vision-granting base in an allied city will give the builder vision.

I think the sensible invariant here is that for city tiles, base owner == border owner; so a base created in a city should be owned by the city's owner, not the builder's.

(This only matters for rulesets which allow vision-granting bases in cities.)


More controversially, I'm not sure about the current behaviour that building any base (but not other extras) takes ownership of existing bases, regardless of whether the new base has meaningful ownership. I wonder whether that behaviour should only apply to bases where ownership has an effect (i.e. vision- and territory-granting bases only).

This could be annoying for ruleset authors; backward player A building a primitive defensive hill-fort can also take ownership and benefit from player B's existing electronic surveillance station, despite being unable to build it themself.

I suppose ruleset authors have enough control to work around this sort of thing -- they can prevent building the hill fort on a tile with the surveillance station (via reqs rather than conflicts).

Probably this belongs in a separate ticket, if we're to do anything about it.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup