bugFreeciv - Bugs: bug #25141, assertion 'cmr->found_a_valid'...

Show feedback again

bug #25141: assertion 'cmr->found_a_valid' failed.

Submitted by:  Marko Lindqvist <cazfi>
Submitted on:  Mon Oct 3 09:38:15 2016  
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: In Progress
Assigned to: NoneOpen/Closed: Open
Release: TRUNK r33962Operating System: None
Planned Release: 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):

You are not logged in

Please log in, so followups can be emailed to you.


Sat Oct 8 19:07:21 2016, comment #2:

This is a bit too complex (-> regression-prone) to fix in S2_5.

Marko Lindqvist <cazfi>
Project Administrator
Wed Oct 5 05:45:56 2016, comment #1:

The problem was that 'best' solution was initialized with zero values, and thus negative solutions were always considered less-than-best. In other words emergency parameter, supposed to accept any, even negative, solution, did not work at all.

Fix attached.

I'm yet to measure if this (considering even negative solutions) gives noticeable performance hit. In any case it could make optimization sense to initialize with minimum surpluses requested, so that solutions unacceptable because of them are not even explored.

(file #28900, file #28901)

Marko Lindqvist <cazfi>
Project Administrator
Mon Oct 3 09:38:15 2016, original submission:

Attached sandbox ruleset autogame assert fails.

#0 raise (sig=6) at ../sysdeps/unix/sysv/linux/raise.c:58
#1 0x00000000006df944 in fc_assert_fail (file=0x73bf4f "../../src/server/cityturn.c",
function=0x73e560 <__FUNCTION__.26626> "auto_arrange_workers", line=408,
assertion=0x73c008 "cmr->found_a_valid", message=0x7bd315 "nologmsg:%s")
at ../../src/utility/log.c:564
#2 0x00000000004a4a8d in auto_arrange_workers (pcity=0x1e4cb70) at ../../src/server/cityturn.c:408
#3 0x000000000058b9f6 in dai_gov_value (ait=0xae46c0 <ai_types>, pplayer=0x2038880, gov=0xef9aa0,
val=0x7fffffffdc1c, override=0x7fffffffdc1b) at ../../../src/ai/default/aidata.c:455
#4 0x000000000054fc99 in cai_gov_value (pplayer=0x2038880, gov=0xef9aa0, val=0x7fffffffdc1c,
override=0x7fffffffdc1b) at ../../../src/ai/classic/classicai.c:261
#5 0x00000000004700f6 in adv_best_government (pplayer=0x2038880)
at ../../../src/server/advisors/advdata.c:810
#6 0x000000000046f678 in adv_data_phase_init (pplayer=0x2038880, is_new_phase=true)
at ../../../src/server/advisors/advdata.c:506
#7 0x000000000043acb5 in begin_phase (is_new_phase=true) at ../../src/server/srv_main.c:1070
#8 0x000000000044040c in srv_running () at ../../src/server/srv_main.c:2578
#9 0x000000000044214f in srv_main () at ../../src/server/srv_main.c:3214
#10 0x00000000004338f1 in main (argc=6, argv=0x7fffffffe0e8) at ../../src/server/civserver.c:482

Marko Lindqvist <cazfi>
Project Administrator


(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):

Attached Files
file #28900:  NegativeSolutionMinimal.patch added by cazfi (1kB - text/plain-diff)
file #28845:  boxcrash.serv added by cazfi (469B - application/octet-stream)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -unavailable- added by cazfi (Submitted the item)

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.


    Error: not logged in



    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Oct 8 19:07:21 2016cazfiStatusReady For Test=>In Progress
      Planned Release2.5.6, 2.6.0, 3.0.0=>2.6.0, 3.0.0
    Wed Oct 5 05:45:56 2016cazfiAttached File-=>Added NegativeSolutionMinimal.patch, #28900
      Attached File-=>Added NegativeSolutionMinimal-S2_5.patch, #28901
      StatusNone=>Ready For Test
      Planned Release=>2.5.6, 2.6.0, 3.0.0
    Mon Oct 3 09:38:15 2016cazfiAttached File-=>Added boxcrash.serv, #28845
    Show feedback again

    Back to the top

    Powered by Savane 3.1-cleanup