bugFreeciv - Bugs: bug #25270, Crash in can_extras_coexist

 
 
Show feedback again

bug #25270: Crash in can_extras_coexist

Submitted by:  mir3x <mir3x>
Submitted on:  Mon Nov 7 11:07:03 2016  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: 2.6, 3.0Operating System: None
Planned Release: 2.6.0, 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Dec 5 13:31:32 2016, comment #1:

I could reproduce the crash, but:

There's tile with two workers where one of them finishes irrigation from swamp (where irrigation is terrain change action) to grassland (where irrigation is extra building action). It has NULL target irrigation activity legally while terrain is swamp, but if it's not cleared soon enough, such an activity is illegal at grassland.

Marko Lindqvist <cazfi>
Project Administrator
Mon Nov 7 11:07:03 2016, original submission:

Savegame attached, just click end turn in qt-client.

Qt client updates menu when unit label changes to get current tooltips for unit label, it doesnt crash in gtk.

#0 0x0000000000663891 in can_extras_coexist (pextra1=0x8c0f80 <extras>, pextra2=0x0) at extras.c:691
691 return !BV_ISSET(pextra1->conflicts, extra_index(pextra2));
[Current thread is 1 (Thread 0x7f9a3d710840 (LWP 16575))]
(gdb) bt
#0 0x0000000000663891 in can_extras_coexist (pextra1=0x8c0f80 <extras>, pextra2=0x0) at extras.c:691
#1 0x000000000074d08b in can_unit_do_activity_targeted_at (punit=0x18cddb0, activity=ACTIVITY_IRRIGATE,
target=0x8c0f80 <extras>, ptile=0x18166e0) at unit.c:915
#2 0x000000000074cf5e in can_unit_do_activity_targeted (punit=0x18cddb0, activity=ACTIVITY_IRRIGATE, target=0x8c0f80 <extras>)
at unit.c:892
#3 0x000000000074cf2e in can_unit_do_activity (punit=0x18cddb0, activity=ACTIVITY_IRRIGATE) at unit.c:881
#4 0x000000000075141c in can_units_do_activity (punits=0x2568450, activity=ACTIVITY_IRRIGATE) at unitlist.c:117
#5 0x00000000004dc1e7 in mr_menu::menus_sensitive (this=0x13064d0) at menu.cpp:1686
#6 0x00000000004c8cbd in update_unit_info_label (punitlist=0x2568450) at mapview.cpp:999

mir3x <mir3x>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29319:  dcc.sav.bz2 added by mir3x (12kB - application/x-bzip)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by jtn (Updated the item)
  • -unavailable- added by mir3x (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Dec 3 10:49:29 2016jtnPlanned Release=>2.6.0, 3.0.0
    Mon Nov 7 11:07:03 2016mir3xAttached File-=>Added dcc.sav.bz2, #29319
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup