bugFreeciv - Bugs: bug #25282, handle_unit_get_actions() may...

 
 
Show feedback again

bug #25282: handle_unit_get_actions() may leak city existence

Submitted by:  Sveinung Kvilhaugsvik <sveinung>
Submitted on:  Thu Nov 10 16:58:24 2016  
 
Category: generalSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Sveinung Kvilhaugsvik <sveinung>Open/Closed: Closed
Release: TRUNKOperating System: Any
Planned Release: 3.1.0, 3.0.0Contains string changes: No

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue Mar 28 20:01:39 2017, SVN revision 35169:

unit_get_actions: stop city existence leakage.

Stop leaking if a previously observed city still exists when responding to
a request for action probabilities in handle_unit_get_actions().

See gna bug #25282

(Browse SVN revision 35169)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Tue Mar 28 20:00:31 2017, SVN revision 35167:

unit_get_actions: stop city existence leakage.

Stop leaking if a previously observed city still exists when responding to
a request for action probabilities in handle_unit_get_actions().

See gna bug #25282

(Browse SVN revision 35167)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Sun Mar 26 17:14:41 2017, comment #5:

v3:

  • improved comments
  • drop target city tile != target tile. It is now impossible.
  • reorganize probability calculation for clarity
Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Wed Mar 22 18:34:46 2017, comment #4:

v2: Don't leak when city id belongs to a city that used to be on a different tile than target tile.

(file #29897)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Sun Mar 19 10:28:28 2017, comment #3:

The previous comment was old state. Ready for test patch.

(file #29892)

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Sun Mar 19 10:27:36 2017, comment #2:

Work in progress patch.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Thu Nov 10 17:10:02 2016, comment #1:

Patch #7974 fixes the case where this bug, given a potentially legal city targeted action with long enough range, can be used to discover new cities.

I'm working on the case where a city's disappearance can be detected.

Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.
Thu Nov 10 16:58:24 2016, original submission:
Sveinung Kvilhaugsvik <sveinung>
Project MemberIn charge of this item.

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by sveinung (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 11 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue Mar 28 20:04:23 2017sveinungStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun Mar 26 17:14:54 2017sveinungAttached File-=>Added 0001-unit_get_actions-stop-city-existence-leakage.patch, #29904
    Sun Mar 26 17:14:41 2017sveinungStatusIn Progress=>Ready For Test
    Wed Mar 22 18:53:27 2017sveinungStatusReady For Test=>In Progress
    Wed Mar 22 18:34:46 2017sveinungAttached File-=>Added 0004-unit_get_actions-stop-city-existence-leakage.patch, #29897
      Planned Release3.0.0=>3.1.0, 3.0.0
    Sun Mar 19 10:28:28 2017sveinungAttached File-=>Added 0015-unit_get_actions-stop-city-existence-leakage.patch, #29892
    Sun Mar 19 10:27:36 2017sveinungStatusIn Progress=>Ready For Test
    Thu Nov 10 17:01:08 2016sveinungDependencies-=>Depends on patch #7975
    Thu Nov 10 16:59:54 2016sveinungDependencies-=>Depends on patch #7974
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup