bugFreeciv - Bugs: bug #25336, often can't conquer empty cities

 
 
Show feedback again

bug #25336: often can't conquer empty cities

Submitted by:  wotan <wotan>
Submitted on:  Wed Nov 23 00:06:24 2016  
 
Category: client-gtk-3.22Severity: 4 - Important
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: r34608Operating System: GNU/Linux
Planned Release: 3.0.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat Jan 21 23:10:33 2017, comment #24:

grep -C 100 assertion bug.log > buglog.exerpt

attached.

(file #29705)

Christian Knoke <chrisk>
Project Member
Sat Jan 21 22:59:34 2017, comment #23:

This is another assertion failed, seen with -d 1

Happens when I goto and ... set home city or, ... You're fired:

1: in send_path_orders() [goto.c::1428]: assertion '!is_non_allied_city_tile(old_tile, client_player()) && !is_non_allied_unit_tile(old_tile, client_player())' failed.
1: Warning: unit or city blocks the path of your Armor
1: Bitte berichten Sie diese Fehlermeldung unter http://gna.org/projects/freeciv/

I tried this with JWM and XFCE4.

Another Desktop: MATE in Jessie:

freeciv-gtk3 -d 3 -l mate.log

after loading the savegame, the client hangs for a very long time 'not ready' with 100 % CPU for the client
nothing seems to happen

3:10 min. CPU time for the client, vs. few seconds in JWM.

Christian

Christian Knoke <chrisk>
Project Member
Sat Jan 21 22:24:01 2017, comment #22:

for the many Iterating over 147-144 x 85-82 rectangle. messages see:

bug #24973

Christian Knoke <chrisk>
Project Member
Sat Jan 21 22:16:22 2017, comment #21:

Wotan played GTK3.22 in 2.6 branch with civ2civ3 ruleset?

I played GTK3 in 3.0 with classic ruleset.

The bug seems to be, there is no popup when unit is next to city and want to get inside.

I cannot reproduce in 2.6 (now), and cannot transfer savegame to 2.6

Still in Trunk/Rev. 34880, recompiled w/ debug=yes

No matter in fullscreen or not
There is no popup, but I have popups for caravans

LANG= freeciv-gtk3 -d 3

When I try to move a marine into the city with 'G'-key goto, I get:

1: in handle_unit_actions() [packhand.c::4597]: assertion 'action_id_get_target_kind(auto_action) == ATK_TILE || action_id_get_target_kind(auto_action) == ATK_UNITS' failed.

Complete -d 3 log for this below.

Maybe related (or not):

starting with -d 4 -l bug.log I get an exorbitantly growing logfile, with 16 KB/sec, while doing nothing - and a total 115 MB in 20 minutes. A lot lines read like this:

4: in fc_randomly_debug() [rand.c::278]: fc_randomly(322,1) = 0 at tilespec.c:4803
4: in update_map_canvas() [mapview_common.c::1374]: Iterating over 147-144 x 85-82 rectangle.
4: in fc_randomly_debug() [rand.c::278]: fc_randomly(322,1) = 0 at tilespec.c:4803
4: in update_map_canvas() [mapview_common.c::1374]: Iterating over 147-144 x 85-82 rectangle.
4: in update_map_canvas() [mapview_common.c::1374]: last message repeated 2 times
4: in update_map_canvas() [mapview_common.c::1374]: last message repeated 2 times (total 4 repeats)
4: in update_map_canvas() [mapview_common.c::1374]: last message repeated 4 times (total 8 repeats)

Christian

-->-->--
3: got packet type=(PACKET_CONN_PING_INFO)116 len=9 from server
3: got packet type=(PACKET_CONN_PING)88 len=4 from server
3: sending packet type=PACKET_CONN_PONG(89) len=4 to server
3: sending request 52
3: got packet type=(PACKET_PROCESSING_STARTED)0 len=4 from server
3: got packet type=(PACKET_PROCESSING_FINISHED)1 len=4 from server
3: sending packet type=PACKET_UNIT_ORDERS(73) len=6 to server
3: sending request 53
3: got packet type=(PACKET_PROCESSING_STARTED)0 len=4 from server
3: got packet type=(PACKET_UNIT_INFO)63 len=16 from server
3: sending packet type=PACKET_UNIT_GET_ACTIONS(87) len=5 to server
3: sending request 54
3: got packet type=(PACKET_PROCESSING_FINISHED)1 len=4 from server
3: got packet type=(PACKET_PROCESSING_STARTED)0 len=4 from server
3: got packet type=(PACKET_UNIT_ACTIONS)90 len=5 from server
1: in handle_unit_actions() [packhand.c::4597]: assertion 'action_id_get_target_kind(auto_action) == ATK_TILE || action_id_get_target_kind(auto_action) == ATK_UNITS' failed.
1: Please report this message at http://gna.org/projects/freeciv/
3: sending packet type=PACKET_UNIT_DO_ACTION(84) len=5 to server
3: sending request 55
3: sending packet type=PACKET_UNIT_SSCS_SET(71) len=5 to server
3: sending request 56
3: got packet type=(PACKET_PROCESSING_FINISHED)1 len=4 from server
3: got packet type=(PACKET_PROCESSING_STARTED)0 len=4 from server
3: got packet type=(PACKET_PROCESSING_FINISHED)1 len=4 from server
3: got packet type=(PACKET_PROCESSING_STARTED)0 len=4 from server
3: got packet type=(PACKET_UNIT_INFO)63 len=16 from server
3: got packet type=(PACKET_PROCESSING_FINISHED)1 len=4 from server
--<--<--

Christian Knoke <chrisk>
Project Member
Fri Jan 20 22:00:32 2017, comment #20:

Just met this bug.

Using GTK3 client in
revision="2.93.99-alpha (r34870)"
rulesetdir="classic"

New game. I can attack cities with ships, missiles, tank, alpines, partisans .. but cannot move into with the land units if it is empty. No message.

That means .. I cannot move into a city with keybord goto and mouse, and cannot move into it, with the arrow keys. No popup, not behind the main window. BUT I can move into the empty city with goto and ... function from the menue (after I found this bug report). Hurray.

All in one turn, yet.

And now I see what after turn done..

Same as before. Only "goto and ..." function can conquer an empty city.

Reproducible from savegame (attached).

I compiled on Debian Jessie with:
./autogen.sh --enable-svnrev --with-readline --enable-ruledit=no --enable-testmatic --enable-client=gtk3 --enable-sys-lua=no --enable-sys-tolua-cmd=no --enable-debug=no --with-missinglist

Christian

(file #29704)

Christian Knoke <chrisk>
Project Member
Fri Dec 30 13:45:50 2016, comment #19:

Do you get the pop up from spy actions and caravan actions?

Sveinung Kvilhaugsvik <sveinung>
Project Member
Fri Dec 30 00:40:42 2016, comment #18:

I get no popup with a normal goto, maybe its hidden below the window?

wotan <wotan>
Thu Dec 29 16:26:08 2016, comment #17:

Weird. I click on the Marine, press "g", click on Maputo, see the action selection dialog pop up, select "Conquer City" and the Marine invades it. ("Goto and..." works too)

Sveinung Kvilhaugsvik <sveinung>
Project Member
Thu Dec 29 08:48:03 2016, comment #16:

argh found it; the only way it works is using Unit -> "goto and.." -> conquer city

not with regular goto, or regular arrow move, since when is this?

wotan <wotan>
Thu Dec 29 08:46:13 2016, comment #15:

no my marines can not enter the town,neither with arrow key or goto mouse

wotan <wotan>
Thu Dec 29 08:34:17 2016, comment #14:

no my marines can not enter the town,neither with arrow key or goto mouse

wotan <wotan>
Thu Dec 29 00:53:19 2016, comment #13:

Thank you for the save game. I just invaded Maputo by using the Marines next to it. (r34743) Are you able to do so too?

Sveinung Kvilhaugsvik <sveinung>
Project Member
Thu Dec 29 00:04:50 2016, comment #12:

try invading empty Maputo with the units surrounding it, it doesn't work here. r34746 trunk gtk 3.22 (default)

(file #29604)

wotan <wotan>
Wed Dec 28 15:00:21 2016, comment #11:

The AI will put a unit in Witqos if I press "Turn Done" in the test save game from the forum. I therefore created a test scenario with the editor. (Give my self a helicopter, give the enemy an empty city, press turn done) The enemy city was empty at the start of my turn. I was able to conquer it with a helicopter.

wotan : do you have any save games where this bug appears after the game has been loaded?

Sveinung Kvilhaugsvik <sveinung>
Project Member
Wed Dec 28 10:07:21 2016, comment #10:

sveinung : also when the city has 0 enemy units at the start of your turn?

wotan <wotan>
Tue Dec 27 16:50:26 2016, comment #9:

I was able to use a Helicopter to conquer Witqos in the Gtk3.22 client. wotan <wotan>: are you able to make Witqos great again with the Helicopter when you load the save game from http://forum.freeciv.org/f/viewtopic.php?f=9&t=49442#p56055 ?

I got the mentioned back trace when I tried to conquer Witqos with a unit that can't be legally used to do so. -> bug #25401

Sveinung Kvilhaugsvik <sveinung>
Project Member
Sun Dec 4 16:22:15 2016, comment #8:

http://forum.freeciv.org/f/viewtopic.php?f=9&t=49442#p56055 is such a savegame ... but it works for me in Gtk3 and Gtk2 clients. (I'm unable to test the Gtk3.22 client the report mentions.)

Jacob Nevins <jtn>
Project Administrator
Sun Dec 4 16:17:06 2016, comment #7:

I didn't trivially reproduce this (trunk r34689, civ2civ3).

Can you attach a savegame where this is happening?

Jacob Nevins <jtn>
Project Administrator
Sun Dec 4 16:11:12 2016, comment #6:

I assume this is trunk, and hence that something is going wrong with the newish "Conquer City" action.

Jacob Nevins <jtn>
Project Administrator
Sun Dec 4 14:46:42 2016, comment #5:

svn r34689 Phalanx can not conquer empty enemy cities please fix this critical bug.
Entire peoples lives are on the line. Developers might be convicted for genocide at the ICC or die in custody if this bug is not fixed.

wotan <wotan>
Sun Nov 27 22:18:45 2016, comment #4:

Marines, Tanks and Howitzers can't invade empty enemy cities either.

wotan <wotan>
Wed Nov 23 11:07:25 2016, comment #3:

If the helicopter or cavalry destroys the last remaining unit itself, it will then move into the city and conquer it succesfully (in default ruleset civ2civ3 you move into the space of the destroyed unit after winning battle). The problem only arises when the unit wants to enter an empty city.

wotan <wotan>
Wed Nov 23 08:30:49 2016, comment #2:

Have u checked other clients ?
I think that in civ2civ3 maybe u can't conquer cities with cavalry/chopper.
( Im not sure)

mir3x <mir3x>
Project Member
Wed Nov 23 00:11:26 2016, comment #1:

last lines of chatlog (not sure if related)

Please report this message at http://gna.org/projects/freeciv/
in expl_act_not_enabl() [unithand.c::826]: assertion 'action_id_get_target_kind(action_id) != ATK_COUNT' failed.
Please report this message at http://gna.org/projects/freeciv/
in action_get_target_kind() [actions.c::702]: assertion 'paction' failed.
Action doesn't exist.
Please report this message at http://gna.org/projects/freeciv/
in action_get_target_kind() [actions.c::702]: assertion 'paction' failed.
Action doesn't exist.
Please report this message at http://gna.org/projects/freeciv/
in expl_act_not_enabl() [unithand.c::826]: assertion 'action_id_get_target_kind(action_id) != ATK_COUNT' failed.
Please report this message at http://gna.org/projects/freeciv/
in dio_put_uint16_raw() [dataio_raw.c::288]: assertion '!((int) (_extension_ ({ unsigned short int _v, __x = (unsigned short int) (x); if (__builtin_constant_p (__x)) __v = ((unsigned short int) ((((__x) >> 8) & 0xff) | (((__x) & 0xff) << 8))); else __asm_ ("rorw $8, %w0" : "=r" (__v) : "0" (__x) : "cc"); __v; })) != value)' failed.
Please report this message at http://gna.org/projects/freeciv/
Trying to put 174341 into 16 bits; it will result 43269 at receiving side.
in dio_put_uint16_raw() [dataio_raw.c::288]: assertion '!((int) (_extension_ ({ unsigned short int _v, __x = (unsigned short int) (x); if (__builtin_constant_p (__x)) __v = ((unsigned short int) ((((__x) >> 8) & 0xff) | (((__x) & 0xff) << 8))); else __asm_ ("rorw $8, %w0" : "=r" (__v) : "0" (__x) : "cc"); __v; })) != value)' failed.
Please report this message at http://gna.org/projects/freeciv/
Trying to put 175302 into 16 bits; it will result 44230 at receiving side.
in action_get_target_kind() [actions.c::702]: assertion 'paction' failed.
Action doesn't exist.
Please report this message at http://gna.org/projects/freeciv/
in action_get_target_kind() [actions.c::702]: assertion 'paction' failed.
Action doesn't exist.
Please report this message at http://gna.org/projects/freeciv/
in expl_act_not_enabl() [unithand.c::826]: assertion 'action_id_get_target_kind(action_id) != ATK_COUNT' failed.
Please report this message at http://gna.org/projects/freeciv/

wotan <wotan>
Wed Nov 23 00:06:24 2016, original submission:

(default ruleset civ2civ3)

Kill all enemy units in a town with a boat or a fighter, then try to enter the empty town with chopper or cavalry. It will not be possible.

wotan <wotan>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29705:  buglog.exerpt.bz2 added by chrisk (8kB - application/x-bzip)
file #29704:  spiel-T0263-Y01774-manual.sav.xz added by chrisk (30kB - application/x-xz)
file #29604:  cantinvadeemptytown.sav.xz added by wotan (79kB - application/octet-stream - maputo conquer fail)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by chrisk (Updated the item)
  • -unavailable- added by sveinung (Posted a comment)
  • -unavailable- added by jtn (Posted a comment)
  • -unavailable- added by mir3x (Posted a comment)
  • -unavailable- added by wotan (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat Jan 21 23:10:33 2017chriskAttached File-=>Added buglog.exerpt.bz2, #29705
    Fri Jan 20 22:00:32 2017chriskAttached File-=>Added spiel-T0263-Y01774-manual.sav.xz, #29704
    Thu Dec 29 00:04:50 2016wotanAttached File-=>Added cantinvadeemptytown.sav.xz, #29604
    Sun Dec 4 16:11:12 2016jtnSeverity3 - Normal=>4 - Important
      Planned Release=>3.0.0
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup