bugFreeciv - Bugs: bug #25448, military_advisor_choose_build -...

 
 
Show feedback again

bug #25448: military_advisor_choose_build - signed integer overflow

Submitted by:  mir3x <mir3x>
Submitted on:  Mon Jan 16 18:35:24 2017  
 
Category: aiSeverity: 3 - Normal
Priority: 5 - NormalStatus: None
Assigned to: NoneOpen/Closed: Open
Release: 2.6.0, 3.0, 3.1Operating System: None
Planned Release: Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon Jan 16 18:35:24 2017, original submission:

danger = MIN(200, 100 * qdanger / our_def) + urgency;

100 * qdanger = 1369706212 * 100 -> overflow

qdanger is danerous close to overflow alone.

Seems danger might go easily to negative value.

in save from game in bug #25446

mir3x <mir3x>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by mir3x (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    No Changes Have Been Made to This Item
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup