bugBattle for Wesnoth - Bugs: bug #25462, Team color not loading correctly...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #25462: Team color not loading correctly in the multiplayer lobby

Submitted by:  Frank <the_gnat>
Submitted on:  Mon Jan 23 02:14:33 2017  
 
Category: BugSeverity: 3 - Normal
Priority: 5 - NormalItem Group: Multiplayer Lobby
Status: FixedPrivacy: Public
Assigned to: Charles Dang <vultraz>Open/Closed: Closed
Release: 1.13.6Operating System: All

(Jump to the original submission Jump to the original submission)

Fri Mar 17 04:11:15 2017, comment #14:

Thank you for all your work! this color issue was really annoying me ;)

Frank <the_gnat>
Sat Mar 11 03:55:58 2017, comment #13:

Er, ignore the comment. I didn't proofread it before I committed it. >_>

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Sat Mar 11 03:50:14 2017, comment #12:

Ok, I found the underlying cause and fixed that too: https://github.com/wesnoth/wesnoth/commit/4d62f42817e11af7fb604f33c3bb5743ffbdf722

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Sat Mar 11 01:47:55 2017, comment #11:

Stuff like ~RC(magenta>7) now gives brown instead of white. I believe it is related to the order of tags in data/core/team_colors.cfg.

As for the behavior of colors in the MP Staging dialog, yes, I did make it so the sprite in both the side list and FLG dialog updates based on the chosen color.

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Sat Mar 11 01:44:27 2017, comment #10:

Maybe so. I have a tendency to open the page when the notification e-mail comes through, finish off whatever I was doing previously, then come back to the bug report. I have quite a delay between when posts actually happen and when Gna sends the notification so I didn't see that you had already replied. :/

Anyway, seems to be working for me now. Must be a new feature in 1.13 or the new lobby. I tested all the colours.

What do you mean by RC colouring? Is that a separate issue?

Wedge009 <wedge009>
Project Member
Sat Mar 11 01:39:40 2017, comment #9:

Anyway, my fix for this bug did not fix the underlying issue, which is that RC coloring by index breaks after "4" or so, but it seems id works perfectly. Will need to investigate further.

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Sat Mar 11 01:37:12 2017, comment #8:

Likely you didn't refresh the page :P I had posted 2.5 minutes earlier.

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Sat Mar 11 01:28:34 2017, comment #7:

WTH? Why do I keep not seeing your replies until later? D:

Wedge009 <wedge009>
Project Member
Sat Mar 11 01:17:55 2017, comment #6:

Uh... wedge? I just found the bug and fixed it :/

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Sat Mar 11 01:14:28 2017, comment #5:

I think this is different. This sounds more to me like a feature request than a bug. In the game, the teams will have the correct colour. But they will remain static in the MP lobby and checking the behaviour in 1.12.x shows that we do not change colour tinting on the units displayed there either.

Wedge009 <wedge009>
Project Member
Sat Mar 11 01:11:49 2017, comment #4:

Ah, I found the problem. It doesn't happen for every single color.

Fixed here: https://github.com/wesnoth/wesnoth/commit/41647cec8305d1de4ae29dc45c4c84ac15115c71

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Fri Mar 10 22:02:14 2017, comment #3:

Hello

I apologize for not responding sooner.

The problem occurs for every leader in the multiplayer menu.

Unfortunately the upload size for GNA is too small so i have posted the screen shots of the problem on the wesnoth forum:

https://forums.wesnoth.org/viewtopic.php?f=5&t=44809&p=609389#p609389

Hopefully you are able to fix this issue, if you need any more information i would be happy to supply it.

Frank <the_gnat>
Thu Feb 9 11:33:38 2017, comment #2:

I cannot reproduce this either.

Charles Dang <vultraz>
Project AdministratorIn charge of this item.
Tue Jan 31 02:01:09 2017, comment #1:

If I understand you correctly, when you have a non-random leader selected in the MP lobby and you change the leader colour selection, the sprite changes dress based on the colour selected.

I could not find this problem in either the current development build nor the 1.13.6 release. Can you submit a screenshot if it's still happening for you, please? Might it only be a problem for one particular leader or does it happen for every leader you choose?

Wedge009 <wedge009>
Project Member
Mon Jan 23 02:14:33 2017, original submission:

When you choose your team color in the multiplayer menu of 1.13.6 certain colors do not show correctly.

If you choose 'white' as your team color it shows the color orange on your leader. Similarily:

'brown' shows white on your leader
'orange' shows black on your leader
'black' shows brown on your leader

Please NOTE: this issue only occurs in the multiplayer lobby NOT in-game.

Thank you and hopefully this can be fixed.

Frank <the_gnat>

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by vultraz (Posted a comment)
  • -unavailable- added by wedge009 (Posted a comment)
  • -unavailable- added by the_gnat (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 9 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun Mar 19 00:17:22 2017vultrazOpen/ClosedOpen=>Closed
    Sat Mar 11 01:28:34 2017wedge009CategoryFeature Request=>Bug
      StatusNone=>Fixed
    Sat Mar 11 01:14:28 2017wedge009CategoryBug=>Feature Request
      StatusFixed=>None
      Operating Systemwindows=>All
    Sat Mar 11 01:11:49 2017vultrazStatusWorks For Me=>Fixed
    Thu Feb 9 11:33:38 2017vultrazStatusNone=>Works For Me
      Assigned toNone=>vultraz
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup