bugFreeciv - Bugs: bug #25628, Crash on Turn Done

 
 
Show feedback again

bug #25628: Crash on Turn Done

Submitted by:  Eric <koqebwix>
Submitted on:  Fri Mar 31 13:06:35 2017  
 
Category: aiSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: Marko Lindqvist <cazfi>Open/Closed: Closed
Release: 2.5.6Operating System: Any
Planned Release: 2.5.7, 2.6.0, 3.0.0, 3.1.0Contains string changes: None

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Mon May 1 17:46:17 2017, SVN revision 35361:

Fix AI crash when there's no suitable ferryboat type

Reported by Eric

See gna bug #25628

(Browse SVN revision 35361)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon May 1 17:46:11 2017, SVN revision 35360:

Fix AI crash when there's no suitable ferryboat type

Reported by Eric

See gna bug #25628

(Browse SVN revision 35360)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon May 1 17:46:03 2017, SVN revision 35359:

Fix AI crash when there's no suitable ferryboat type

Reported by Eric

See gna bug #25628

(Browse SVN revision 35359)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon May 1 17:45:55 2017, SVN revision 35358:

Fix AI crash when there's no suitable ferryboat type

Reported by Eric

See gna bug #25628

(Browse SVN revision 35358)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon May 1 16:44:16 2017, comment #15:

carsh.sav.bz2 was caused by the same bug. If you still have crashes after this is fixed (I may make a test build as soon as tomorrow), please report them to our new bug tracker http://www.hostedredmine.com/projects/freeciv/issues/new
(All of gna.org is going to shut down, so we need to migrate away)

Your modpack looks good. Maybe you want to share it at modpacks forum at http://forum.freeciv.org/f/viewforum.php?f=11
Some of the sprites could be useful for me in an another modpack, but then we would need out to sort out their licensing etc.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon May 1 14:30:03 2017, comment #14:

I meant release 2.5.7... As you can see my thoughts are already set to what can be done for 2.5.8.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon May 1 14:28:34 2017, comment #13:

As you said it's crashing often, I'd want to do some autogame testing with your ruleset to see if there's more similar AI problems happening with it. Unfortunately there's too many things on my plate already, so it will probably happen only after 2.5.8 release, so won't yield results to that release.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Apr 30 09:34:43 2017, comment #12:

OK.
Thank you again for your help.
At least I can stop trying to find what I have done wrong :)

Eric <koqebwix>
Sun Apr 30 08:57:12 2017, comment #11:

They are source code pathes, so you can't really use them if you don't build freeciv yourself. They are here mainly for other developers to review before they are accepted to freeciv repository. Hopefully they get in before next freeciv release. 2.5.7 shouldn't be too many weeks away.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Sun Apr 30 08:40:11 2017, comment #10:

Thank you!
But how do I use this?

Eric <koqebwix>
Sun Apr 30 05:42:33 2017, comment #9:

Attached patches fix at least newcrash.sav.bz2 case.

(file #29948, file #29949, file #29950)

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Mon Apr 3 09:39:16 2017, comment #8:

I finaly have a hint:
I tried to play without constructing bases, and it doesn't crash (for now)

Eric <koqebwix>
Sat Apr 1 08:32:16 2017, comment #7:

The mod is too big to upload here.
You can download it here :
http://server2.xcel7.com/publiset/koqmod.zip

Eric <koqebwix>
Sat Apr 1 08:26:19 2017, comment #6:

Hello again.
It didn't take long to crash this time...
So here's the new crashing saved game and the mod.

(file #29911)

Eric <koqebwix>
Sat Apr 1 06:17:09 2017, comment #5:

Thanks for the help.
I'll be back as soon as possible!

Eric <koqebwix>
Sat Apr 1 06:15:41 2017, comment #4:

OK.
But I have modified some files in the misc and amplio2 directory...
So what I must do is make my own tileset instead before sending you anything.

I suppose the saved game will not be compatible after that :(
So I will have to play again and when it crashes, send you another saved game with my mod this time.

This could take some time, because the crash is somewhat rare.

Eric <koqebwix>
Fri Mar 31 15:50:24 2017, comment #3:

Yes, the ruleset would be needed too. Sorry for not noticing the part about you using your own ruleset.

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Mar 31 13:56:31 2017, comment #2:

I suppose you will need all files of the mod too... if you want to run the saved game.

Eric <koqebwix>
Fri Mar 31 13:17:05 2017, comment #1:

> But when it crashes, it crashes again if I restart with the last saved game.


Can you attach such a savegame to reproduce the problem?

Marko Lindqvist <cazfi>
Project AdministratorIn charge of this item.
Fri Mar 31 13:06:35 2017, original submission:

Hello.

Freeciv crashes sometimes when I click "Turn Done".
I really don't have any explanation, because I just can't see a pattern.
But when it crashes, it crashes again if I restart with the last saved game.

Sometimes when I load another saved game (like 1 or 2 turns before), it crashes again at the same turn... but sometimes not.
The crash may come in the first 10 turns or at turn 150 (like I said : no pattern)

Maybe it's something I modified in the effects.rulest or a new unit or building... (I'm using my own ruleset and tileset)
But I'm pretty sure I have done it right.

Is there a known crash with an effect?

(I'm using Freeciv 2.5.6 GTK+2 client on Windows XP, playing against AI players only)

Sorry for my English, it's not my first language...

Eric <koqebwix>

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #29948:  LackOfFerryboatCrash.patch added by cazfi (867B - text/plain-diff)
file #29949:  LackOfFerryboatCrash-S2_5.patch added by cazfi (818B - text/plain-diff)
file #29950:  LackOfFerryboatCrash-S2_6.patch added by cazfi (855B - text/plain-diff)
file #29911:  newcrash.sav.bz2 added by koqebwix (43kB - application/octet-stream)
file #29910:  crash.sav.bz2 added by koqebwix (67kB - application/octet-stream - Here's a crashing saved game)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by cazfi (Posted a comment)
  • -unavailable- added by koqebwix (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Error: not logged in

     

     

    Follow 13 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon May 1 17:46:38 2017cazfiStatusReady For Test=>Fixed
      Assigned toNone=>cazfi
      Open/ClosedOpen=>Closed
    Sun Apr 30 05:50:12 2017cazfiCategorygeneral=>ai
    Sun Apr 30 05:42:33 2017cazfiAttached File-=>Added LackOfFerryboatCrash.patch, #29948
      Attached File-=>Added LackOfFerryboatCrash-S2_5.patch, #29949
      Attached File-=>Added LackOfFerryboatCrash-S2_6.patch, #29950
      Categoryclient-gtk-2.0=>general
      StatusNone=>Ready For Test
      Operating SystemMicrosoft Windows=>Any
      Planned Release=>2.5.7, 2.6.0, 3.0.0, 3.1.0
    Sat Apr 1 08:26:19 2017koqebwixAttached File-=>Added newcrash.sav.bz2, #29911
    Fri Mar 31 13:54:07 2017koqebwixAttached File-=>Added crash.sav.bz2, #29910
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup