bugSavane - Bugs: bug #2839, voting-system.sql fails

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #2839: voting-system.sql fails

Submitted by:  Sylvain Beucler <beuc>
Submitted on:  Sat 03 Sep 2005 08:01:00 AM UTC  
 
Category: DatabaseStatus: Fixed
Severity: 5 - BlockerPriority: A - Later
Assigned to: Mathieu Roy <yeupou>Open/Closed: Closed
Release: 1.0.8Planned Release: 1.0.8+1
Reproducibility: NonePrivacy: Public

Wed 07 Sep 2005 01:49:01 PM UTC, comment #4:

With 99, voting appears before Advanced. It does not seems to be a big issue but I'm not 100% sure old version reserved number before 99. The easier way is to rewrite accordingly voting-system.sql.

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Sun 04 Sep 2005 11:48:53 AM UTC, comment #3:

> Well, you're the author of this code, aren't you? :)


Right, but it's just an upgrade sql script so...

> I never understood why every ID starts at 100. Do you know about this?


That's the way the original author of the bug tracker designed it.

> Also I don't think reserving a fixed set of IDs is a good solution.


In many cases, it's necessary. But in this case, we cannot reserve idea that were available in all previous versions.

>
> Adding a new query form in a generic way would better be done using a Perl or
> PHP script.
>


That's an option. We can replace the sql script by a perl script.

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Sun 04 Sep 2005 08:19:51 AM UTC, comment #2:

> I'm not sure it really matter that this query form get the
> id 102.
>
> Would not it work if you replace 102 in
> update/1.0.8/voting-system.sql by an
> unused number?


Well, you're the author of this code, aren't you? :)

> BTW, strangely enough, there are at least one project using
> a non standard query form and there was no issue to get the
> voting system in place.


Interesting, what is the first non-default query-form ID, at Gna! ?
The code in editqueryforms.php doesn't seem to generate the ID itself, delegating that task to MySQL, so I should have used #102 at first glance.

> Maybe we should use 99 as id for this query form, it would
> avoid the issue; we have to check first whether it would not
> implies that this field get shown in first place (that would
> not be nice).


I never understood why every ID starts at 100. Do you know about this?

Also I don't think reserving a fixed set of IDs is a good solution.

Adding a new query form in a generic way would better be done using a Perl or PHP script.

I have no clue about the order issue. I guess it takes whatever order MySQL uses, which may be sorted by ID by default. Adding an index may be the way to cleanly fix this if that's needed.

Sylvain Beucler <beuc>
Project Administrator
Sat 03 Sep 2005 08:25:37 AM UTC, comment #1:

I'm not sure it really matter that this query form get the id 102.

Would not it work if you replace 102 in update/1.0.8/voting-system.sql by an unused number?

BTW, strangely enough, there are at least one project using a non standard query form and there was no issue to get the voting system in place.

Maybe we should use 99 as id for this query form, it would avoid the issue; we have to check first whether it would not implies that this field get shown in first place (that would not be nice).

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Sat 03 Sep 2005 08:01:00 AM UTC, original submission:

ERROR 1062 at line 37: Duplicate entry '102' for key 1

In Savannah some people created new query forms, so 102 isn't free.
This is a very rarely used feature (48 at Savannah), so maybe you don't have any here.

Anyway you can't reserve another one for default. The default table_bugs_report.initvalues is incompatible with older installs now.

Sylvain Beucler <beuc>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yeupou (Posted a comment)
  • -unavailable- added by beuc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 07 Sep 2005 02:16:20 PM UTCyeupouStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
      Planned Release1.1 / 1.0.8+1=>1.0.8+1
    Wed 07 Sep 2005 01:49:01 PM UTCyeupouStatusNone=>In Progress
      Assigned toNone=>yeupou
    Sat 03 Sep 2005 08:27:07 AM UTCyeupouRelease=>1.0.8
      Planned Release=>1.1 / 1.0.8+1
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup