bugSavane - Bugs: bug #313, RFC822 compliance

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #313: RFC822 compliance

Submitted by:  Sylvain Beucler <beuc>
Submitted on:  Wed 24 Mar 2004 12:25:00 AM UTC  
 
Category: Web FrontendStatus: Fixed
Severity: 3 - NormalPriority: C - Normal
Assigned to: Mathieu Roy <yeupou>Open/Closed: Closed
Release: >= 1.0.1Planned Release: 1.0.2
Reproducibility: NonePrivacy: Public

Fri 26 Mar 2004 06:51:08 PM UTC, comment #4:

Ok, it should be it with the current CVS, however it should probably more widely tested than I am able to do on my test install.

How it works: the preferred usage of sendmail_mail() is now to give it login names. He will format it appropriately under the form user_getrealname() <user_getmail()>. And user_getrealname() have no an argument to makes it returning (supposedly) RFC822 compliant strings, adding quotes when he found strange characters.

This way, it is easy to just give login name and not bother with this issue.

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Fri 26 Mar 2004 05:57:17 PM UTC, comment #3:

For the last point, I think we already "escape" the quotes and antislashes by removing them and disallowing users to put them in their account name.

More generally, I think that the following characters does not belong to a clean user real name , ; : \ "

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Wed 24 Mar 2004 04:51:40 PM UTC, comment #2:

After reading the RFC (http://www.ietf.org/rfc/rfc0822.txt?number=822) I saw that strings are required as soon as there are 'special characters' (and optional otherwise):

specials = "(" / ")" / "<" / ">" / "@" ; Must be in quoted-
/ "," / ";" / ":" / "\" / <"> ; string, to use
/ "." / "[" / "]" ; within a word.

Also, to be perfectly compatible, one should escape " and \, in case the user put them its 'Real Name' field.

Sylvain Beucler <beuc>
Project Administrator
Wed 24 Mar 2004 02:32:47 PM UTC, comment #1:

Interesting. Do you know if the quote are standard, or just required when there is a special character within the name string?

Mathieu Roy <yeupou>
Project AdministratorIn charge of this item.
Wed 24 Mar 2004 12:25:00 AM UTC, original submission:

In www/include/trackers/general.php:980
< $from = user_getrealname().' <noreply@'.$GLOBALS['sys_default_domain'].'>';
---

> $from = '"'.user_getrealname().'" <noreply@'.$GLOBALS['sys_default_domain'].'>';


See http://mail.gnu.org/archive/html/savannah-hackers/2004-03/msg00253.html

Sylvain Beucler <beuc>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yeupou (Updated the item)
  • -unavailable- added by beuc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 26 Mar 2004 06:51:08 PM UTCyeupouSeverity1 - Wish=>3 - Normal
      StatusNone=>Fixed
      Assigned toNone=>yeupou
      Open/ClosedOpen=>Closed
    Wed 24 Mar 2004 02:32:47 PM UTCyeupouRelease*=>>= 1.0.1
      Planned Release=>1.0.2
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup