bugSavane - Bugs: bug #416, News HTML layout is broken

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #416: News HTML layout is broken

Submitted by:  Vincent Caron <zerodeux>
Submitted on:  Thu 10 Jun 2004 10:20:49 AM UTC  
 
Category: Web FrontendStatus: None
Severity: 3 - NormalPriority: C - Normal
Assigned to: Vincent Caron <zerodeux>Open/Closed: Closed
Release: Planned Release: 
Reproducibility: NonePrivacy: Public

Fri 11 Jun 2004 09:25:37 AM UTC, comment #3:

Fixed.

Vincent Caron <zerodeux>
Project MemberIn charge of this item.
Thu 10 Jun 2004 12:21:34 PM UTC, comment #2:

Sure, OK for the quick fix, I'm having a try.

I was actually lead to think along the same lines ("this thing need to be totally CSS'ed one day, die tables, die !").

Vincent Caron <zerodeux>
Project MemberIn charge of this item.
Thu 10 Jun 2004 12:08:42 PM UTC, comment #1:

I do not agree with the idea 2 since I think it will break several other pages and will reduce the flexibility of news_show_latest()

Also, the box model already accept multiple row. In an awkward way, but still it works. Doing the kind of modification are likely to break several other things.

I suggest that we just stick to basic fix, at least on trunk.

Proposal:

Modifying news_show_latest so it prints "</td></tr><tr><td>" the begin of any newline except the first one.

I do not remember exactly how looks like this function but I think it should be feasible. Moreover, it is in a similar way that multiples rows (that are in every tables) are handled. The issue here is only the fact it print from the start a <tr><td> while it should assume this is already done (like it already assumes that <table> is open).

I do not think the way the html output is implemented is wonderfull but changing it would require a dense work - so to avoid breaking other parts or break the logic of the whole thing, we should stick to it until we implement something different.

Regards,

Mathieu Roy <yeupou>
Project Administrator
Thu 10 Jun 2004 10:20:49 AM UTC, original submission:

As read from /index.php:

$HTML->box1_top(...);
echo news_show_latest(...);
$HTML->box1_bottom();

The trouble is that box1_top() starts a <table><tr><td>, box1_bottom() ends with </td></tr></table, and news_show_latest() should ouput regular content.

But news_show_latest() makes assumption on its context, and outputs news items in <tr><td>...</td></tr> elements, trying to extend the box model, ant it fails :

[box1_top:]
<table>
<tr>
<td>
[news_show_latest:]
<tr><td> ... item ... </td></tr>
<tr><td> ... item ... </td></tr>
[box1_bottom:]
</td>
</tr>
</table>

Proposed solution:

1- improve the box model in Layout.php to accept multiple rows of content

2- move the box_ calls into news_show_latest, have only the global news header passed as argument to news_show_latest

Vincent Caron <zerodeux>
Project MemberIn charge of this item.

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by yeupou (Posted a comment)
  • -unavailable- added by zerodeux (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Fri 11 Jun 2004 09:25:37 AM UTCzerodeuxAssigned toNone=>zerodeux
      Open/ClosedOpen=>Closed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup