Savane - Bugs: bug #5662, Patch request for... [Gna!]

Savane - Bugs: bug #5662, Patch request for...

Group

Main
- Main
- View Members
- Search
Homepage
Download
Docs
- Browse
- Submit
- Edit
- Digest
- Export
- Search
Support
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Mailing Lists
Source Code
- Use Subversion
- Browse Sources Repository
Bugs
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
Tasks
- Browse
- Reset to all open ones
- Submit
- Digest
- Export
- View Statistics
- Search
News
- Browse
- Atom Feed
- Submit
- Manage

Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #5662: Patch request for include/news/forum.php

Submitted by:	Marcus Hardt <marcus>
Submitted on:	Mon 03 Apr 2006 11:18:37 AM UTC

Category:	Web Frontend: News	Status:	Fixed
Severity:	1 - Wish	Priority:	C - Normal
Assigned to:	None	Open/Closed:	Closed
Release:	1.0-1.4	Planned Release:	2.0
Reproducibility:	None	Privacy:	Public

Fri 15 Sep 2006 12:16:02 PM UTC, comment #5: I've just tested, that php just returns the empty string. So if unset there's no problem. It's a useless feature. This variable is also used in the sv_forum.pl script that is not part of savane. I will introduce these checks into the perl script, just to be safe.	Marcus Hardt <marcus>
Fri 15 Sep 2006 11:23:33 AM UTC, comment #4: In fact I never liked it. I shall insert a check on the GLOBALS variable and set it to "" if unset. I'll do that later today.	Marcus Hardt <marcus>
Fri 15 Sep 2006 10:35:28 AM UTC, comment #3: Considering that sys_lists_prefix does not exists, what should we do about it?	Mathieu Roy <yeupou>
Fri 15 Sep 2006 10:07:35 AM UTC, comment #2: The original implementation was such that the emails that are sent to a forum where constructed like this: ${sys_list_prefix}_${forum_name}_${project_name}@${sys_hostname} This patch contains (among others) the change to ${sys_list_prefix}${forum_name}... As far as I can see, the rest are code beautifications	Marcus Hardt <marcus>
Thu 14 Sep 2006 02:05:43 PM UTC, comment #1: Hello Markus, Your patch refers to sys_list_prefix, what is it?	Mathieu Roy <yeupou>
Mon 03 Apr 2006 11:18:37 AM UTC, original submission: Hi There! I've upgraded from 1.0.0 to 1.4 and was glad to find my old code of the forums. Would you be so kind to apply the following patch to frontend-php/include/news/forum.php The patch improves the overall format of mails sent by the forum.php. It's somewhat tested in the prod-environment (i.e. 1.0.0), but only quicktested in 1.4. I don't expect problems	Marcus Hardt <marcus>

Attached Files

file #750: forum.php.diff added by marcus (4kB - text/x-diff)

Depends on the following items: None found

Items that depend on this one

release 2.0 (was 1.5) (task #2862, Done)

Digest:
task dependencies.

Carbon-Copy List

-unavailable- added by yeupou (Updated the item)

-unavailable- added by marcus (Submitted the item)

Do you think this task is very important?
If so, you can click here to add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

Please enter the title of George Orwell's famous dystopian book (it's a date):

Follow 7 latest changes.

Date	Changed By	Updated Field	Previous Value	Replaced By
Fri 22 Sep 2006 02:32:21 PM UTC	yeupou	Status	Need Info	Fixed
		Open/Closed	-Automatic update due to transitions settings-	Closed
Thu 14 Sep 2006 02:05:43 PM UTC	yeupou	Status	Confirmed	Need Info
Thu 14 Sep 2006 01:52:47 PM UTC	yeupou	Status	None	Confirmed
		Planned Release		2.0
		Open/Closed	-Automatic update due to transitions settings-	Open
Mon 03 Apr 2006 11:18:37 AM UTC	marcus	Attached File	-	Added forum.php.diff, #750

Show feedback again