bugSavane - Bugs: bug #851, Commas in Real Name not supported

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #851: Commas in Real Name not supported

Submitted by:  Sylvain Beucler <beuc>
Submitted on:  Tue 05 Oct 2004 09:12:04 PM UTC  
 
Category: BackendStatus: Postponed
Severity: 3 - NormalPriority: A - Later
Assigned to: NoneOpen/Closed: Open
Release: Planned Release: 
Reproducibility: NonePrivacy: Public

Wed 23 May 2007 09:46:40 PM UTC, comment #4:

http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=136
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=135
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=134
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=133
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=132
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=131
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=130
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=129
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=128
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=127
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=126
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=125
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=124
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=123
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=122
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=121
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=120
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=119
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=118
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=117
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=116
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=115
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=114
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=113
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=112
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=111
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=110
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=109
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=108
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=107
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=106
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=105
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=104
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=103
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=102
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=101
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=100
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=99
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=98
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=97
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=96
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=95
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=94
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=93

http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=92
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=91
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=90
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=89
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=88
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=87
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=86
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=85
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=84
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=83
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=82
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=81
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=80
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=79
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=78
http://csmaster.sxu.edu/mcauley/phpbb2/viewtopic.php?t=77
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=397
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=447
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=446
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=445
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=444
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=443
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=442
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=412
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=411
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=410
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=409
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=408
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=407
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=406
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=405
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=404
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=403
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=402
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=401
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=400
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=399
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=398
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=427
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=426
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=425
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=424
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=423
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=422
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=420
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=421
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=419
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=418
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=417
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=416
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=415
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=414
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=413
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=442
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=441
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=440
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=439
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=438
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=437
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=436
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=435
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=434
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=433
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=432
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=431
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=430
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=429
http://www.pucpr.edu/facultad/hvera/forum/topic.asp?TOPIC_ID=428

john book <dedes151>
Tue 09 Nov 2004 04:34:57 PM UTC, comment #3:

In fact, ',' was allowed both at registration and name change. I modified the frontend so it removes any commas found, until the backend is modified in this regard.

Mathieu Roy <yeupou>
Project Administrator
Wed 06 Oct 2004 08:56:50 AM UTC, comment #2:

The user name was something like "Jim Lowe, Jr.", so the use of the comma was justified IMHO.

Currently I do not have the time to do that task, since I am still working on the merge with the Savannah changes, but I could do it after if nobody did.

Sylvain Beucler <beuc>
Project Administrator
Wed 06 Oct 2004 08:45:03 AM UTC, comment #1:

"It seems the GetDB() procedure as well as its calls should be rewritten thorough Savane so as to return a table instead of a string."

In my opinion, the problem is the fact that an user was able to enter a real name (or whatever field) with a comma.

I think the account creation process disallow that already. But maybe the "change name" page does not do the appropriate checks.

"It seems the GetDB() procedure as well as its calls should be rewritten thorough Savane so as to return a table instead of a string."

That could be something interesting to do. When I wrote GetDB, I just grabbed the way things were done in sv_cvs, the original backend. The point was to having more or less the same code reorganized. This step being achieved, we can perfectly improve it.
And I think that each time GetDB() is called, we transform it into a list with split(). So if GetDB() returning a list, that would be definitely cleaner and would avoid this bug.

Mathieu Roy <yeupou>
Project Administrator
Tue 05 Oct 2004 09:12:04 PM UTC, original submission:

The code that parses the MySQL query result in DB.pm joins everything with a ","; hence, when there is a comma in the Real Name of a user account, things are shifted.

What is pretty unfortunate is that scripts seem to rely on this structure, eg sv_users.pl splits the result using split(","). As a consequence the SSH keys are replaced by a part of the Real Name and the account is not updated well.

It seems the GetDB() procedure as well as its calls should be rewritten thorough Savane so as to return a table instead of a string.

Sylvain Beucler <beuc>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by dedes151 (Posted a comment)
  • -unavailable- added by yeupou (Posted a comment)
  • -unavailable- added by beuc (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 3 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 09 Nov 2004 04:34:57 PM UTCyeupouPriorityC - Normal=>A - Later
      StatusNone=>Postponed
    Wed 06 Oct 2004 08:45:17 AM UTCyeupouPriorityA - Later=>C - Normal
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup