See also sr #1640

I'm using the option 'root_as_url_component = 0' in my viewcvs.conf file. That means that my revision pages (that are linked to) look like
this

The link the latest savane produces is
this

It puts an ? before rev instead of a &.

In the code I found:

$out .= '<p>(<a href="'.$svn_link.'?rev='.$entry['revision'].'&amp;view=rev">'.sprintf(_("Browse SVN revision %s"), $entry['revision']).'</a>)</p>';

So changing it to:

$out .= '<p>(<a href="'.$svn_link.'&amp;rev='.$entry['revision'].'&amp;view=rev">'.sprintf(_("Browse SVN revision %s"), $entry['revision']).'</a>)</p>';

fixes it.

The underlying problem is (I think) that savane assumes that all links to the viewcvs front end contain the project name as a directory. For example:
http://svn.gna.org/viewcvs/savane/?...

In my case that doesn't work.

We should/could check $svn_link. If there is already an ? in that string we need to use an &, if it doesn't we should use an &. If this is ok I can commit a fix like that to the trunk.