bugWarzone 2100 Project - Bugs: bug #10852, Getting rid of huge of busy loop...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #10852: Getting rid of huge of busy loop in atmos.c

Submitted by:  Bugs Buggy <buginator>
Submitted on:  Wed 23 Jan 2008 04:23:49 AM UTC  
 
Category: Engine: GraphicsSeverity: Important
Priority: 5 - NormalStatus: Confirmed
Assigned to: NoneOpen/Closed: Open
Release: svn/trunkOperating System: All
Planned Release: 2.2

Wed 12 Mar 2008 07:26:23 PM UTC, comment #2:

Changed back for 2.1

Per I. Mathisen <per>
Project Administrator
Wed 23 Jan 2008 07:49:44 AM UTC, comment #1:

It was part of my work to improve the renderer, and, eventually, do away with the current VISIBLE_X|YTILES altogether. For starters, I managed to make it local to display3d.c. Instead I think we should use some kind of frustrum culling to define the actually seen view space, which is often far less than the defined 64x64 of the current view space.

I would be for changing it back to use VISIBLE_X|YTILES for the 2.1 branch when it is created. For trunk, I think we should instead find a better and more long-term solution.

Per I. Mathisen <per>
Project Administrator
Wed 23 Jan 2008 04:23:49 AM UTC, original submission:

in r2996, "Remove unused function. Remove unnecessary references to VISIBLE_X|YTILES."

I think that was a bit premature, and causes a huge performance hit, since we do not have any other clipping code in atmos.c, we basically have a big busy loop.

The define should be changed back to:
#define MAX_ATMOS_PARTICLES ((VISIBLE_XTILES * VISIBLE_YTILES))

Would be nice also if the log would be more verbose as to why you think it is unnecessary. (This goes for most all log entries, not just this one)

Bugs Buggy <buginator>
Project Administrator

 

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by per (Posted a comment)
  • -unavailable- added by buginator (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 12 Mar 2008 07:26:23 PM UTCperPlanned ReleaseNone=>2.2
    Wed 23 Jan 2008 07:49:44 AM UTCperStatusNone=>Confirmed
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup