bugSavane - Bugs: bug #14678, SVN commit message truncation not...

 
 
Show feedback again

You are not allowed to post comments on this tracker with your current authentification level.

bug #14678: SVN commit message truncation not working.

Submitted by:  Edward d Auvergne <bugman>
Submitted on:  Wed 04 Nov 2009 01:36:17 PM UTC  
 
Category: BackendStatus: None
Severity: 3 - NormalPriority: C - Normal
Assigned to: NoneOpen/Closed: Open
Release: r6514 trunkPlanned Release: 
Reproducibility: NonePrivacy: Public

Thu 12 Nov 2009 04:14:50 PM UTC, comment #1:

Attached is a simple patch which tries to address this bug, and generally improve how svn commit logs are handled (especially with respect to svnmerge mayhem). This handles 3 situations:

1). Normal SVN commit logs of < 50 lines. Here the current operation is preserved.

2). Normal SVN commit log of > 50 lines. Hopefully I have activated how this should have been handled! The log attached to the tracker is truncated to 50 lines, terminated by "\n[...]".

3). Svnmerge autogenerated commit messages from HELL! These are caught (the string matching method is not so great though). Only the first 2 lines are attached to the tracker, identifying the revisions merged and the appropriate merge location in the svn repository.

Note that in all 3 cases, the bug, task, sr, or patch references throughout the entire commit message are identified and later used for attaching $log to the appropriate trackers.

(file #7290)

Edward d Auvergne <bugman>
Wed 04 Nov 2009 01:36:17 PM UTC, original submission:

The problem is shown at https://gna.org/bugs/?13259#comment9. I submitted the issue of ridiculous svnmerge logs as https://gna.org/support/?2426, but noticed a bug in ./backend/extra/subversion/sv_extra_svn_postcommit_brigde.pl on line 150-154 (r6514 trunk) which would alleviate the pain.

The log looks like it should end with [...]. Instead because there is no breaking out of the while loop, the text '[...]' is being preprended to the output and the entire log replicated. A better solution would be to avoid svnmerge logs entirely and I suggested an idea for this as a response to ESR's message at https://mail.gna.org/public/support-requests/2009-11/msg00019.html.

Cheers,

Edward

Edward d Auvergne <bugman>

 

Attached Files
file #7290:  svnmerge_log_fix added by bugman (1kB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bugman (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follows 1 latest change.

    Date Changed By Updated Field Previous Value => Replaced By
    Thu 12 Nov 2009 04:14:50 PM UTCbugmanAttached File-=>Added svnmerge_log_fix, #7290
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup