bugFreeciv - Bugs: bug #17121, Server settings lost when copying...

 
 
Show feedback again

bug #17121: Server settings lost when copying settings from 2.2.x to 2.3.x

Submitted by:  Jacob Nevins <jtn>
Submitted on:  Sun 21 Nov 2010 02:31:30 PM UTC  
 
Category: clientSeverity: 3 - Normal
Priority: 5 - NormalStatus: Fixed
Assigned to: pepeto <pepeto>Open/Closed: Closed
Release: Operating System: GNU/Linux
Planned Release: 2.3.0

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Sat 27 Nov 2010 12:02:43 PM UTC, SVN revision 18626:

Keep compatibility with the old server desired setting in client side.

Reported by Jacob Nevins .

See gna bug #17121.

(Browse SVN revision 18626)

pepeto <pepeto>
Project MemberIn charge of this item.
Sat 27 Nov 2010 12:02:43 PM UTC, SVN revision 18625:

Keep compatibility with the old server desired setting in client side.

Reported by Jacob Nevins .

See gna bug #17121.

(Browse SVN revision 18625)

pepeto <pepeto>
Project MemberIn charge of this item.
Mon 22 Nov 2010 11:22:02 PM UTC, comment #5:

Looks plausible and works for me. Thanks!

Jacob Nevins <jtn>
Project Administrator
Sun 21 Nov 2010 07:28:11 PM UTC, comment #4:

Fix attached, ugly.

(file #11329)

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 21 Nov 2010 03:32:23 PM UTC, comment #3:

I will try to improve this.

pepeto <pepeto>
Project MemberIn charge of this item.
Sun 21 Nov 2010 03:22:58 PM UTC, comment #2:

(I think I must last have hit "Save" in the client in S2_2 prior to the fix for bug #15185, since my rc-2.2 has values for all the server settings, whereas hitting "Save" on S2_2 now only saves options that differ from the current default. That means my log is noisier than many people's will be, but doesn't invalidate my point.)

Jacob Nevins <jtn>
Project Administrator
Sun 21 Nov 2010 02:55:47 PM UTC, comment #1:

In fact it seems like these errors will persist until the first time the user explicitly hits "save" on the client's server options dialog -- otherwise the client's copy of the server options are not changed, even if the client overwrites the RC file (e.g., if it has "Save Options on Exit" enabled) -- the [server] part continues to have the exact text copied from the 2.2 RC.

Jacob Nevins <jtn>
Project Administrator
Sun 21 Nov 2010 02:31:30 PM UTC, original submission:

I just deleted my ~/.freeciv-client-rc-2.3 file to simulate what a user upgrading to 2.3.x from an earlier version would see (without having used SVN versions in the meantime, as us devs have).

I got a load of warnings for server settings that the 2.2 RC file specifies numerically, as numeric values are no longer accepted for boolean/enumerated/etc settings. These settings are now at the (2.3.x) defaults.

This is a shame, especially as some settings are accepted; I guess it might lead to an unplayable default configuration which users will have to fix up manually when they first play (say, startpos not matching size).

Could we accept numeric settings at least when reading old RC-files? Can 2.3.x even still understand what the old numbers mean (now that they're stored textually in files, the numbers are effectively internal and could have changed), and will it continue to in future? (I haven't investigated this.)

Console:

Client chat log:

My current .freeciv-client-rc.2.2 attached, for completeness.

Jacob Nevins <jtn>
Project Administrator

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #11320:  .freeciv-client-rc-2.2 added by jtn (8kB - application/octet-stream - My current 2.2 client settings)

 

Depends on the following items

Digest:
   patch dependencies.

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by pepeto (Posted a comment)
  • -unavailable- added by jtn (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sat 27 Nov 2010 12:02:52 PM UTCpepetoStatusReady For Test=>Fixed
      Open/ClosedOpen=>Closed
    Sun 21 Nov 2010 07:30:18 PM UTCpepetoDependencies-=>Depends on patch #2225
    Sun 21 Nov 2010 07:28:11 PM UTCpepetoAttached File-=>Added 0002-Keep-compatibility-with-the-old-server-desired-setti.patch, #11329
      StatusNone=>Ready For Test
    Sun 21 Nov 2010 03:32:23 PM UTCpepetoAssigned toNone=>pepeto
    Sun 21 Nov 2010 02:39:55 PM UTCjtnSummarySettings lost when copying settings from 2.2.x to 2.3.x=>Server settings lost when copying settings from 2.2.x to 2.3.x
    Sun 21 Nov 2010 02:31:30 PM UTCjtnAttached File-=>Added .freeciv-client-rc-2.2, #11320
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup