Keep compatibility with the old server desired setting in client side.

Reported by Jacob Nevins .

See gna bug #17121.

(Browse SVN revision 18625)

Fix attached, ugly.

(file #11329)

(I think I must last have hit "Save" in the client in S2_2 prior to the fix for bug #15185, since my rc-2.2 has values for all the server settings, whereas hitting "Save" on S2_2 now only saves options that differ from the current default. That means my log is noisier than many people's will be, but doesn't invalidate my point.)

I just deleted my ~/.freeciv-client-rc-2.3 file to simulate what a user upgrading to 2.3.x from an earlier version would see (without having used SVN versions in the meantime, as us devs have).

I got a load of warnings for server settings that the 2.2 RC file specifies numerically, as numeric values are no longer accepted for boolean/enumerated/etc settings. These settings are now at the (2.3.x) defaults.

This is a shame, especially as some settings are accepted; I guess it might lead to an unplayable default configuration which users will have to fix up manually when they first play (say, startpos not matching size).

Could we accept numeric settings at least when reading old RC-files? Can 2.3.x even still understand what the old numbers mean (now that they're stored textually in files, the numbers are effectively internal and could have changed), and will it continue to in future? (I haven't investigated this.)

Console:

Client chat log:
Freeciv is free software and you are welcome to distribute copies of it under certain conditions; See the "Copying" item on the Help menu. Now ... Go give 'em hell! Starting server... Welcome to the Freeciv version 2.2.99-dev Server running at teacup port 5556. You are logged in as 'jtn' connected to Jtn. Established control over the server. You have command access level 'hack'. jtn: 'set size 3' Option: size has been set to 3. jtn: 'set topology 5' /set: No match for "5". jtn: 'set generator 1' /set: No match for "1". jtn: 'set startpos 0' /set: No match for "0". jtn: 'set tinyisles 0' /set: No match for "0". jtn: 'set separatepoles 1' /set: No match for "1". jtn: 'set alltemperate 0' /set: No match for "0". jtn: 'set huts 75' Option: huts has been set to 75. jtn: 'set maxplayers 30' Option: maxplayers has been set to 30. jtn: 'set aifill 6' Option: aifill has been set to 6. AI*1 has been added as Easy level AI-controlled player. jtn: 'set ec_turns 2' Option: ec_turns has been set to 2. jtn: 'set ec_max_size 100' Option: ec_max_size has been set to 100. jtn: 'set ec_chat 1' /set: No match for "1". jtn: 'set ec_info 0' /set: No match for "0". jtn: 'set autoattack 0' /set: No match for "0". jtn: 'set killcitizen 1' /set: No match for "1". jtn: 'set borders 1' /set: No match for "1". jtn: 'set happyborders 1' /set: No match for "1". jtn: 'set diplomacy 0' /set: No match for "0". jtn: 'set citynames 2' /set: No match for "2". jtn: 'set barbarians 2' /set: No match for "2". jtn: 'set fogofwar 1' /set: No match for "1". jtn: 'set foggedborders 0' /set: No match for "0". jtn: 'set spacerace 1' /set: No match for "1". jtn: 'set endspaceship 1' /set: No match for "1". jtn: 'set savepalace 1' /set: No match for "1". jtn: 'set naturalcitynames 1' /set: No match for "1". jtn: 'set migration 1' /set: No match for "1". jtn: 'set mgr_foodneeded 1' /set: No match for "1". jtn: 'set mgr_distance 3' Option: mgr_distance has been set to 3. jtn: 'set autotoggle 0' /set: No match for "0". jtn: 'set phasemode 0' /set: No match for "0". jtn: 'set turnblock 1' /set: No match for "1". jtn: 'set fixedlength 0' /set: No match for "0". jtn: 'set compresstype 2' /set: No match for "2". jtn: 'set savename civgame' Option: savename has been set to "civgame". jtn: 'set scorelog 0' /set: No match for "0".

My current .freeciv-client-rc.2.2 attached, for completeness.