bugBattle for Wesnoth - Bugs: bug #18591, Multiplayer Game Crashes when...

 
 
Show feedback again

bug #18591: Multiplayer Game Crashes when loading or starting a second game

Submitted by:  Thonsew <thonsew>
Submitted on:  Tue 30 Aug 2011 04:25:51 AM UTC  
 
Category: BugSeverity: 4 - Important
Priority: 5 - NormalItem Group: Multiplayer
Status: NonePrivacy: Public
Assigned to: NoneOpen/Closed: Open
Release: 1.9.8+svnOperating System: linux

Add a New Comment (Rich MarkupRich Markup):
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Thu 26 Jul 2012 08:59:04 PM UTC, comment #1:

During a multiplayer game using Wesnoth 1.10.0 my client vanished suddenly, crashing without warning. The error message in my stderr file said I should report it here.

I was playing my scenario Fall of Trent using Bob's RPG Era. The crash happened just before my leader (my only unit) was killed by an orcish assassin.

A bug in my add-on accounts for the multiple instances of this: "error engine: could not de-serialize unit: game_error: creating unit with an empty type field". But after that it seems there are lots of problems with assigning ids to clones. I've attached the full report.

It was a multiplayer game, and I believe it was a reload. I don't think any of the other players crashed.

(file #16202)

Bob <bob_the_mighty>
Tue 30 Aug 2011 04:25:51 AM UTC, original submission:

In multiplayer, game data is being incompletely reset, when loading new games. At the least the unit_map is not being reset, but there may be other structures not being reset. I am not familiar enough with multiplayer to fix this problem.

The particulars of the unit_map problem follow.
When n_unit::id_manager.clear() is called it resets the unit_ids to 0. However unit_map is not reset when id_manager.clear() is called, so there may be units stranded in the unit_map. Subsequently, if there is an id collision in the unit_map and it asks for a new id there will be many additional collisions.

Someone who knows the intent of the functions in multiplayer_connect calling id_manager.clear needs to determine what other portions of the game logic also need to be reset.

I have masked the crash in the unit_map by ignoring the first million collisions.

I added an error message referring to this bug report requesting specific information to replicate the bug.

Thonsew <thonsew>
Project Member

 

(Note: upload size limit is set to 1024 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #16466:  stderr.txt added by spookymagician (88kB - text/plain - heres mine... I was playing my addon UGS and we reloaded with a different player in MP. Me/-stf-/pkz were wondering what was going on... Maybe this is what caused the problem...?)
file #16202:  error_report.txt added by bob_the_mighty (18kB - text/plain)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by spookymagician (Updated the item)
  • -unavailable- added by gabba
  • -unavailable- added by thonsew (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 03 Sep 2012 02:23:30 AM UTCspookymagicianAttached File-=>Added stderr.txt, #16466
    Thu 26 Jul 2012 08:59:04 PM UTCbob_the_mightyAttached File-=>Added error_report.txt, #16202
    Mon 05 Dec 2011 05:41:22 PM UTCanonymissimusSeverity3 - Normal=>4 - Important
      Priority3 - Low=>5 - Normal
    Fri 04 Nov 2011 10:15:46 PM UTCanonymissimusStatusNeed Info=>None
    Sat 10 Sep 2011 09:40:29 PM UTCgabbaCarbon-Copy-=>Added gabba
    Show feedback again

    Back to the top


    Powered by Savane 3.1-cleanup